Feeling Lucky
?
?
?
[#32935] - [4.0] Fix README.md for unit tests
- Fixed in Code Base
- 31 Mar 2021
- Medium
- Build: 4.0-dev
- # 32935
- Diff
- richard67:4.0-dev-fix-typo-from-pr-32758
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
- Fix typo
phpunit-xmlinstead ofphpunit.xmlfrom PR #32758 . - Remove the
joomla-cmsfrom paths in the description added by PR #32758 so that relative paths below the root folder of the checkout are used, like it is already for the given instructions "2. Runcomposer installin the root of your checkout." and "4. Runlibraries/vendor/bin/phpunit".
I should have noticed that when reviewing that PR #32758 , but seems I was sleeping or blind.
Testing Instructions
Review.
Actual result BEFORE applying this Pull Request
Wong file name phpunit-xml instead of phpunit.xml used.
Inconsistent use of paths with and without the checkout root folder joomla-cms.
Expected result AFTER applying this Pull Request
Right file name phpunit.xml used.
Consistent use of relative paths below the checkout root folder`.
Documentation Changes Required
This is the documentation change.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Unit Tests Repository |
meinhoonharsh
- comment
- 30 Mar 2021
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32935.
| Status | Pending | ⇒ | Ready to Commit |
alikon
- comment
- 30 Mar 2021
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32935.
| Labels |
Added:
?
?
|
||
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-03-31 16:15:39 |
| Closed_By | ⇒ | rdeutz | |
| Labels |
Added:
?
|
||
astridx
- comment
- 2 Apr 2021
@richard67 Thanks for correcting my PR.
I have tested this item✅ successfully on e87f892
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32935.