Feeling Lucky
?
[#32883] - [3.10] Add back com_joomlaupdate default.min.js
- Fixed in Code Base
- 29 Mar 2021
- Medium
- Build: 3.10-dev
- # 32883
- Diff
- richard67:3.10-dev-add-back-joomlaupdate-minified-js
User tests: Successful: Unsuccessful:
Pull Request for Issue #31200 (comment) .
Summary of Changes
Add back the minified js which has been removed with #31200 .
I've used https://jscompress.com/ to minify the js.
Testing Instructions
Make sure that the Joomla Update Component javascript stuff (pre-update checker, quickicon) still works with the minified js.
Actual result BEFORE applying this Pull Request
No minified js present.
Expected result AFTER applying this Pull Request
Minified js is present and used, the Joomla Update component works as well as before.
Documentation Changes Required
None.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript |
| Labels |
Added:
?
|
||
ceford
- comment
- 29 Mar 2021
@richard67 - thanks for the clarification, I was confused by the date on the original issue: commented on 22 Oct 2020 •
zero-24
- comment
- 29 Mar 2021
Ok will merge here on review after confirming that the minified version is 1:1. Thanks @richard67
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-03-29 17:04:36 |
| Closed_By | ⇒ | zero-24 |
Just a comment: I have local install created with git import of joomla-cms (files dated 12 March) and in which the missing file is present:
<script src="/j4test/media/com_joomlaupdate/js/default.min.js?561cadc6377b18079d6e2bda22abbef2" defer></script>And it is there. So I doubt deleting and applying the patch will tell me anything. I don't know how my installation came to have a file it should not have.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32883.