? ? Pending

User tests: Successful: Unsuccessful:

avatar richard67
richard67
27 Mar 2021

Pull Request for Issue # .

Summary of Changes

Change wrong <td> to <th> in table header of the required PHP settings in the pre-update checker.

Testing Instructions

Code review, or check the update checker and inspect markup before and after applying the patch for this PR.

Actual result BEFORE applying this Pull Request

See the green elliptic marks in the following screenshots for how it should be, and red what is wrong.

2021-03-27_j310-pre-update-check-before-th-fix

2021-03-27_j310-pre-update-check-before-th-fix_html

Expected result AFTER applying this Pull Request

2021-03-27_j310-pre-update-check-after-th-fix

2021-03-27_j310-pre-update-check-after-th-fix_html

Documentation Changes Required

None.

avatar richard67 richard67 - open - 27 Mar 2021
avatar richard67 richard67 - change - 27 Mar 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 27 Mar 2021
Category Administration com_joomlaupdate
avatar richard67 richard67 - change - 27 Mar 2021
The description was changed
avatar richard67 richard67 - edited - 27 Mar 2021
avatar chmst chmst - test_item - 27 Mar 2021 - Tested successfully
avatar chmst
chmst - comment - 27 Mar 2021

I have tested this item successfully on d4dd7ec


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32884.

avatar Quy Quy - test_item - 27 Mar 2021 - Tested successfully
avatar Quy
Quy - comment - 27 Mar 2021

I have tested this item successfully on d4dd7ec


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32884.

avatar Quy Quy - change - 27 Mar 2021
Status Pending Ready to Commit
Labels Added: ?
avatar Quy
Quy - comment - 27 Mar 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32884.

avatar zero-24
zero-24 - comment - 27 Mar 2021

Merging thanks ?

avatar zero-24 zero-24 - change - 27 Mar 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-03-27 16:10:55
Closed_By zero-24
Labels Added: ?
avatar zero-24 zero-24 - close - 27 Mar 2021
avatar zero-24 zero-24 - merge - 27 Mar 2021
avatar richard67
richard67 - comment - 27 Mar 2021

Thanks for tests and merge.

Add a Comment

Login with GitHub to post a comment