? ? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
25 Mar 2021

I was doing some work today with the new subfields and I found it quite difficult to explain. I think that instead of saying

"This plugin lets you create new fields of type 'subfields' in any extension where custom fields are supported."

We change it so that field is called subform and the fields inside it are just fields

"This plugin lets you create new fields of type 'subform' that contains one or more fields in any extension where custom fields are supported."

avatar brianteeman brianteeman - open - 25 Mar 2021
avatar brianteeman brianteeman - change - 25 Mar 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 25 Mar 2021
Category Administration Language & Strings
avatar ChristineWk
ChristineWk - comment - 25 Mar 2021

Sorry I'm not sure, because with Patch, I get:

screen shot 2021-03-25 at 20 53 30
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32864.

avatar brianteeman
brianteeman - comment - 25 Mar 2021

That is because I did not want to change the type of the field at this late stage

avatar dgrammatiko
dgrammatiko - comment - 25 Mar 2021

Why not renaming also the plugin to subform? Seems weird that the filesystem has a subfields name and all the other references now are subform. Reminds me of the com_finder- smart search paradigm and I always found that very unintuitive...

avatar brianteeman
brianteeman - comment - 26 Mar 2021

I can do that but its a bigger change.

avatar Quy Quy - test_item - 27 Mar 2021 - Tested successfully
avatar Quy
Quy - comment - 27 Mar 2021

I have tested this item successfully on 22967ae


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32864.

avatar AndySDH
AndySDH - comment - 28 Mar 2021

After thinking about this more, I think 'Subform' may not be the best name either. I'm fine with it, but could be changed.

As 'subform' implies you can create a little form inside a bigger form. But it's the opposite, this field type IS the bigger form, which will contain child fields.

So a few alternative ideas:

  • Parent Field
  • Nested Fields
  • Grouped Fields
  • Multi-Fields
  • Fields Container
  • Fields Collection
  • Rabbit Hole (jk :D )
  • or something along these lines...

I think Nested Fields may be the one that makes most sense, after all it's exactly what it's doing:
https://en.wikipedia.org/wiki/Nesting_(computing)

nesting is where information is organized in layers, or where objects contain other similar objects.

Just throwing some ideas.

Or Subform is fine too. Doesn't really matter much, as long as it works :D

avatar joomdonation joomdonation - test_item - 17 Apr 2021 - Tested successfully
avatar joomdonation
joomdonation - comment - 17 Apr 2021

I have tested this item successfully on 22967ae


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32864.

avatar richard67 richard67 - change - 17 Apr 2021
Status Pending Ready to Commit
Labels Added: ? ?
avatar richard67
richard67 - comment - 17 Apr 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32864.

avatar joomdonation
joomdonation - comment - 17 Apr 2021

I think the change in this PR is good, it make it consistent with other field plugins which we are having at the moment. Once this PR is merged, we will try to change the plugin to make it become real Subform.

avatar rdeutz rdeutz - change - 19 Apr 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-04-19 06:18:44
Closed_By rdeutz
Labels Added: ?
avatar rdeutz rdeutz - close - 19 Apr 2021
avatar rdeutz rdeutz - merge - 19 Apr 2021
avatar brianteeman
brianteeman - comment - 19 Apr 2021

Thanks for testing and merging

Add a Comment

Login with GitHub to post a comment