[#32865] - removed obsolete bootstrap classes
- Closed
- 10 May 2021
- Medium
- Build: 4.0-dev
- # 32865
- Diff
- Vaibhav-afk:4.0-dev
User tests: Successful: Unsuccessful:
Pull Request for Issue #31218
Summary of Changes
-
I did changes in:
1. default_login.php. 2. renderfield.php
Output:
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End com_users Layout NPM Change |
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-03-25 20:34:47 |
| Closed_By | ⇒ | Vaibhav-afk | |
| Labels |
Added:
NPM Resource Changed
?
|
||
| Status | Closed | ⇒ | New |
| Closed_Date | 2021-03-25 20:34:47 | ⇒ | |
| Closed_By | Vaibhav-afk | ⇒ |
| Status | New | ⇒ | Pending |
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-03-25 20:35:57 |
| Closed_By | ⇒ | Vaibhav-afk |
| Status | Closed | ⇒ | New |
| Closed_Date | 2021-03-25 20:35:57 | ⇒ | |
| Closed_By | Vaibhav-afk | ⇒ |
| Status | New | ⇒ | Pending |
I did the changes please review.
| Category | Front End com_users Layout NPM Change | ⇒ | Front End com_users Layout |
The original issue mentioned Bootstrap 4 but Joomla 4 is now using Bootstrap 5 and form-group has been removed. So this PR is wrong!
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32865.
Thank you for contributing. You cannot know this, of course, but as you see in the comment above it is not as easy task. There are 3rd party extension which use these classes for their own js and css - so we cannot remove classes as you did in the default_login.
@chmst I think I see: control-group was changed to form-group when Joomla 4 planned to use Bootstrap 4 and the recent decision to use Bootstrap 5 has come too late to change all 170 instances of form-group to mb-3 in Joomla core extensions. I don't see where third party extensions come in. If they have to change control-group anyway why not change to mb-3. I guess there are more complications than I can shake a stick at.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32865.
This probably should be closed
Closing per #32865 (comment), Thank you for your contribution.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-05-10 14:17:41 |
| Closed_By | ⇒ | Quy | |
| Labels |
Added:
?
Removed: NPM Resource Changed |
||
Did you checked how the login page look after your changes? You are changing more classes than necessary for the issue mentioned.
And do your changes have side effects on other forms?