[#32863] - [4.0] Fix for Button Log out staying when session manager is file
- Closed
- 31 Jul 2021
- Medium
- Build: 4.0-dev
- # 32863
- Diff
- rdeutz:followup_29007
User tests: Successful: Unsuccessful:
Follow up on PR #29007
Summary of Changes
When the session manager is file and you are trying to log out a user in the frontend, the Log Out Button doesn't go away. The reason is that we still have a row in the session table.
The user is loged out and when you refresh the frontend the button is going away in the backend. That's kind of confusing because it looks as it hadn't worked.
Testing Instructions
- Set session mananger to file
- Create a user
- Login with the user in the frontend
- Login with a superuser account in the backend
- Try to log out the user you are logged in in frontend
You should see that the button stays
- Go to the frontend an refresh the page
Now you can see that the Button is not longer there after refreshing the backend
- Apply this PR
- Login with the user in the frontend
- Login with a superuser account in the backend
- Try to log out the user you are logged in in frontend
Button goes away.
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Documentation Changes Required
no
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Plugins |
Also, we have MetadataManager class https://github.com/joomla/joomla-cms/blob/4.0-dev/libraries/src/Session/MetadataManager.php and as I understand, it's used to manage session meta data. I wonder if we should move the logic for deleting meta data which you added here into that class and use it?
Ignore this. It could be done in a separate PR if we want because looking more at the code, we have code to delete session meta data manually in other place, too (not via MetadataManager class) - for example, in ApplicationModel in com_config
| Labels |
Added:
?
|
||
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-04-03 10:03:22 |
| Closed_By | ⇒ | rdeutz |
| Status | Closed | ⇒ | New |
| Closed_Date | 2021-04-03 10:03:22 | ⇒ | |
| Closed_By | rdeutz | ⇒ |
| Status | New | ⇒ | Pending |
@richard67 thanks for the reminder, done
@rdeutz There is still one case which haven't addressed by this PR:
- Track Session Metadata in Global Configuration set to Yes.
- Force Logout for all Sessions? parameter in the User - Joomla! plugin set to No
- Session Handle is not database
In this case, if user logged out himself (from frontend for example), the session meta data for his session is not being deleted, so he is still being displayed in Logged-in Users in backend dashboard. That should be fixed, something we will have to process on this block of code
joomla-cms/plugins/user/joomla/joomla.php
Line 395 in 7c08180
OK, fine. I will try to make a different PR to address that case later.
@sandramay0905 Drone seems to be hanging for this PR. That can happen in very rare cases. Will be fixed when @rdeutz will update his branch, but @rdeutz please wait with that until the 4.0-dev branch is fixed, see #33028 .
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32863.
This should be fixed after the upmerge from staging without this PR - we now use https://github.com/joomla/joomla-cms/blob/4.0-dev/libraries/src/User/UserHelper.php#L606 - could someone test please
cannot reproduce even me, so closing it
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-07-31 09:49:09 |
| Closed_By | ⇒ | alikon |
Can also not reproduce.
This is not working if Force Logout for all Sessions? parameter in User - Joomla! plugin set to No. Also, maybe you should merge #29007 into your PR so that it is easier to test? @SharkyKZ deleted his branch, so it is not easy to test his PR (it could not be tested using Patch tester component)