[#32827] - [4.0] BS beta 3
- Fixed in Code Base
- 25 Mar 2021
- Medium
- Build: 4.0-dev
- # 32827
- Diff
- dgrammatiko:4.0-dev—bs3
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
Beta 3
Testing Instructions
Open the cassiopeia/index.php and add
- After line
joomla-cms/templates/cassiopeia/index.php
Line 97 in 621e20c
HTMLHelper::_('bootstrap.offcanvas');- after line
joomla-cms/templates/cassiopeia/index.php
Line 174 in 621e20c
<button class="btn btn-primary" type="button" data-bs-toggle="offcanvas" data-bs-target="#offcanvasExample" aria-controls="offcanvasExample">
<b>OFF-CANVAS-TEST</b>
</button>
<div class="offcanvas offcanvas-start" tabindex="-1" id="offcanvasExample" aria-labelledby="offcanvasExampleLabel">
<div class="offcanvas-header">
<h5 class="offcanvas-title" id="offcanvasExampleLabel">Offcanvas</h5>
<button type="button" class="btn-close text-reset" data-bs-dismiss="offcanvas" aria-label="Close"></button>
</div>
<div class="offcanvas-body">
<div>
Some text as placeholder. In real life you can have the elements you have chosen. Like, text, images, lists, etc.
</div>
</div>
</div>You should have an off canvas like:
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Documentation Changes Required
I wrote some documentation on using Bootstrap (the interactive parts) here: https://gist.github.com/dgrammatiko/efb3de4aa7cab4813a244f93f73cc0fd
If someone could move this to the Joomla docs I would appreciate it
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | NPM Change |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32827.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32827.
| Status | Ready to Commit | ⇒ | Pending |
| Category | NPM Change | ⇒ | JavaScript Repository NPM Change Libraries |
| Labels |
Added:
NPM Resource Changed
|
||
Ok support for off-canvas added
Guess we need here some more tests.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32827.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32827.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32827.
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-03-25 14:36:32 |
| Closed_By | ⇒ | rdeutz | |
| Labels |
Added:
?
|
||
I have tested this item✅ successfully on 51fb55e
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32827.