[#32828] - [4.0] Automate build versioning
- Fixed in Code Base
- 24 Mar 2021
- Medium
- Build: 4.0-dev
- # 32828
- Diff
- dgrammatiko:4.0-dev—build-versioning
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
This is only for maintainers, move on
Summary of Changes
Just adding the CLI command in the build.php. My hope that I would have completed the work on the build process evaporated with the new beta of Bootstrap.
Testing Instructions
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Documentation Changes Required
@wilsonge you've asked for this one, I should have updated that PR, my bad...
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Repository |
| Labels |
Added:
?
|
||
Mostlikly false positive but will come back here once I looked into the report :-)
I know I said build.php but thinking about it I guess bump.php is the better place? Because this will need to be committed to the repo right with the version bump etc. Sorry to be a pita
Because this will need to be committed to the repo right with the version bump
Actually, you can't commit this back :( The reason is that the versioning is done in the media/**/joomla.asset.json files which are in the exclusion zone. But you shouldn't worry about this as the versioning will invalidate all the files that need a new hash in the next build (the hash is derived by the actual content so we are totally safe here) as long as the process always includes the versioning script per release (which will happen automatically with this PR)
I have restarted drone and fixed the false positive
Oh yes! I'm being stupid! This is fine then
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-03-24 16:38:01 |
| Closed_By | ⇒ | rdeutz |
@SniperSister or @zero24 can someone have a look rips failed