? ? Pending

User tests: Successful: Unsuccessful:

avatar joomdonation
joomdonation
20 Mar 2021

Summary of Changes

Similar to the merged PR #32535 , this PR improves the code add breadcrumbs in category view of com_contact component. The code which we are having right now is a mess, hard to understand and difficult to maintain.

Testing Instructions

  1. Update your site to latest 4.0-dev.
  2. Access to Components -> Contacts-> Categories, create several categories and sub-categories.
  3. Apply patch
  4. Test and make sure the breadcrumbs are still handled properly.

Test 1:

  • Create a menu item to link to List All Categories in a Contact Category Tree menu item type of contacts component. Choose the parent category in the menu item parameter.
  • Access to that menu item, you will see categories list. Access to a child category , look at the breadcrumbs module, make sure breadcrumbs items are added properly (should have the format Home -> Menu Item Title -> Child Category)

Test 2:

  • Create a menu item to link to List Contacts in a Category menu item type of contact component. Choose a child category (which contains contacts)
  • Access to that menu item, you should see list of contacts added to that category, look at look at the breadcrumbs module, make sure breadcrumb item are added properly (should have the format Home -> Menu Item Title)

If someone can review the code changes, that would be great.

avatar joomdonation joomdonation - open - 20 Mar 2021
avatar joomdonation joomdonation - change - 20 Mar 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 20 Mar 2021
Category Front End com_contact
avatar ChristineWk
ChristineWk - comment - 20 Mar 2021

Test 1: > see Edit in new comment. Thks.
Test 2: I'm sorry, maybe I made a mistake:

screen shot 2021-03-20 at 21 59 06


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32765.

avatar ChristineWk
ChristineWk - comment - 20 Mar 2021

Sorry .....

Test 1: also failed. Because I forgot: "Access to a child category ..."
So, got same response - see above.

screen shot 2021-03-20 at 23 31 10


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32765.

avatar joomdonation
joomdonation - comment - 21 Mar 2021

@ChristineWk Could you please make sure you are using latest Joomla 4.0-dev code? I believe your Joomla installation is outdated and that's the reason you see that warning.

avatar joomdonation joomdonation - change - 21 Mar 2021
Labels Added: ?
avatar joomdonation joomdonation - change - 21 Mar 2021
The description was changed
avatar joomdonation joomdonation - edited - 21 Mar 2021
avatar ChristineWk
ChristineWk - comment - 21 Mar 2021

@joomdonation

Joomla CMS Joomla! 4 Content Management System. Site File No Problems 4.0.0-2021-02-28 ‎4.0.0-beta8-dev
Using: https://update.joomla.org/core/nightlies/next_major_list.xml

Will start/try again with Nightly from today.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32765.

avatar joomdonation
joomdonation - comment - 21 Mar 2021

@ChristineWk That is outdated version to test this PR (this PR uses some code from this merged PR #32535 - which only merged few days ago). So Yes, please help testing using nightly build .

avatar ChristineWk
ChristineWk - comment - 21 Mar 2021

@joomdonation

Aha OK. Because I'm also checked this: https://github.com/joomla/joomla-cms/tree/4.0-dev/administrator/components/com_admin/sql/updates/mysql

4.0.0-2021-02-28


Will load from today x adv. laterThis comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32765.
avatar ChristineWk ChristineWk - test_item - 21 Mar 2021 - Tested successfully
avatar ChristineWk
ChristineWk - comment - 21 Mar 2021

I have tested this item successfully on f59ef38

1st test from Nightly 18mar2021
2nd test from Nightly today = OK.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32765.

avatar Harmageddon Harmageddon - test_item - 21 Mar 2021 - Tested successfully
avatar Harmageddon
Harmageddon - comment - 21 Mar 2021

I have tested this item successfully on f59ef38

Tested on a current 4.0-dev version from git. Code also looks good to me.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32765.

avatar richard67 richard67 - change - 21 Mar 2021
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 21 Mar 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32765.

avatar rdeutz rdeutz - change - 22 Mar 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-03-22 06:24:17
Closed_By rdeutz
Labels Added: ?
avatar rdeutz rdeutz - close - 22 Mar 2021
avatar rdeutz rdeutz - merge - 22 Mar 2021

Add a Comment

Login with GitHub to post a comment