[#32767] - Fix warnings on php 8
- Fixed in Code Base
- 23 Mar 2021
- Medium
- Build: staging
- # 32767
- Diff
- joomdonation:fix_warnings_on_php8
User tests: Successful: Unsuccessful:
Pull Request for Issue #31473.
Summary of Changes
This PR fixes PHP warnings on PHP 8. The error happens in some of our view classes because some changes in how php handles string to number comparision:
- Before php 8: 'root' > 1 return false, so the code inside this block https://github.com/joomla/joomla-cms/blob/staging/components/com_content/views/category/view.html.php#L270-L275 won't be run, thus $category variable never has null value, thus we do not get the warnings
- With php8: 'root' > 1 return true, the code inside the block is executed, $category return null and we have the warnings.
Testing Instructions
- You need to have PHP 8 running to test this PR
- Unpublish all menu items you created to link to one of the following menu item types: List All Categories, Category List, Category Blog.
- Create an instance of Articles - Categories, publish it
- Access to a category which is displayed in the module above
Before patch: You would get the warning like
Attempt to read property "id" on null in components/com_content/views/category/view.html.php
After patch: No warning anymore
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End com_contact com_content |
Drone failure was unrelated. I‘ve restarted the job, hope it will pass this time. It seems that when we have too many jobs in the queue or running, we sometimes run into this kind of problem.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32767.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32767.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32767.
| Labels |
Added:
?
?
|
||
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-03-23 16:25:18 |
| Closed_By | ⇒ | rdeutz | |
| Labels | |||
Anyone knows why drone is failing for this PR?