? Pending

User tests: Successful: Unsuccessful:

avatar rjharishabh
rjharishabh
20 Mar 2021

Summary of Changes

Checkbox placed inline with the label in login model

Actual result BEFORE applying this Pull Request

check_old

Expected result AFTER applying this Pull Request

check_new

avatar rjharishabh rjharishabh - open - 20 Mar 2021
avatar rjharishabh rjharishabh - change - 20 Mar 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 20 Mar 2021
Category Front End com_users
avatar rjharishabh rjharishabh - change - 20 Mar 2021
The description was changed
avatar rjharishabh rjharishabh - edited - 20 Mar 2021
avatar brianteeman
brianteeman - comment - 20 Mar 2021

This is a valid issue but the proposal is obviously not correct as the classes are not applied correctlty

avatar rjharishabh
rjharishabh - comment - 20 Mar 2021

This is a valid issue but the proposal is obviously not correct as the classes are not applied correctlty

are you talking about 'controls' class

avatar rjharishabh rjharishabh - change - 20 Mar 2021
Labels Added: ?
avatar saumyasarkar11
saumyasarkar11 - comment - 20 Mar 2021

This is a valid issue but the proposal is obviously not correct as the classes are not applied correctlty

are you talking about 'controls' class

Remove the checkbox from the div with class "contents-label" and create a specific div for it with class ''controls" and then wrap both the divs in one row. Should be alright.

avatar rjharishabh
rjharishabh - comment - 21 Mar 2021

Remove the checkbox from the div with class "contents-label" and create a specific div for it with class ''controls" and then wrap both the divs in one row. Should be alright.

can I use span instead of div

avatar saumyasarkar11
saumyasarkar11 - comment - 21 Mar 2021

Remove the checkbox from the div with class "contents-label" and create a specific div for it with class ''controls" and then wrap both the divs in one row. Should be alright.

can I use span instead of div

It's better to keep the code as original as possible. Avoid using span

avatar rjharishabh
rjharishabh - comment - 21 Mar 2021

I tried to apply this patch but it said : The patch could not be applied because it conflicts with a previously applied patch: components/com_users/tmpl/login/default_login.php

can you please tell me more about it

avatar drmenzelit
drmenzelit - comment - 21 Mar 2021

Keep it simple with correct HTML structure. Probably you don't need a div nor a span element. The control classes are remains from Bootstrap 2 used in Joomla 3.

avatar rjharishabh
rjharishabh - comment - 21 Mar 2021

Keep it simple with correct HTML structure. Probably you don't need a div nor a span element. The control classes are remains from Bootstrap 2 used in Joomla 3.

Thanks

avatar saumyasarkar11
saumyasarkar11 - comment - 22 Mar 2021

I think you should create an issue first regarding this. What say? @rjharishabh

avatar rjharishabh
rjharishabh - comment - 22 Mar 2021

I think you should create an issue first regarding this. What say? @rjharishabh

Yes sure, I will create an issue for this.

avatar rjharishabh rjharishabh - close - 22 Mar 2021
avatar rjharishabh rjharishabh - change - 22 Mar 2021
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2021-03-22 04:07:52
Closed_By rjharishabh
avatar drmenzelit
drmenzelit - comment - 22 Mar 2021

You don't need to create an issue, you can make a PR directly

Add a Comment

Login with GitHub to post a comment