Feeling Lucky
?
[#3275] - [#33450] Don't load tags layouts unless there are tags
- Closed
- 24 Mar 2014
- Medium
- Build: staging
- # 3275
- Diff
- wilsonge:patch-5
- Foreign ID 33450
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
The tags JLayout because some tags info is always set in $this->item->tags The solution is to check for the actual tags themselves rather than the full tags system.
Testing
- Test the tags layout is shown in the frontend by viewing an article without tags. Adding a
die;at the top of the layout (https://github.com/joomla/joomla-cms/blob/staging/layouts/joomla/content/tags.php) should kill your page.
APPLY PR
- Check your article without tags. The page should load happily now because the JLayout isn't being loaded.
- Check an article with tags and ensure the tags still show as expected in the frontend (don't forget to remove the die)
infograf768
- | Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-03-24 10:34:27 |
Bakual
-
@test works