User tests: Successful: Unsuccessful:
In the previous version of Chosen, one could render a select
element with class name chzn-done
so that Chosen would skip it and not try to treat it with the Chosen UI.
This is no longer possible since version 3.2.3 and no alternative way to render regular select is provided.
Proposed is the addition of the check for the class chzn-done
like it used to be.
Labels |
Labels |
Added:
?
|
I think we should not change anything in external libraries like chosen.
We really should get rid of applying chosen to each <select>
and instead apply it to the (default) class advancedSelect
. That would solve it without having to make changes to the library.
Isn't the Chosen library in J3.2.3 already modified by Joomla? I can see different <JUI>
wrappers in there.
I agree though, one way or another, it should be possible to render a simple select
and not force Chosen for all of them.
I see chzn-done
in previous version, strange that they removed it,
but add data-chosen="bla"
to <select>
will have same effect, maybe this is cause
think this pull has the right to life
but would be good add <JUI>
for part of the code that you hacked, in way as it already in chosen.js, and description on the top comment
There is no method to add data-chosen="bla" to config XML, while the previously available "chzn-done" class did the trick.
In the interim, I'm using javascript to destroy the chosen instance for specific inputs:
$('#elementid').chosen('destroy');
It's terribly inefficient to create the instance and then destroy it - but what's the alternative for XML?
Just found this commit from the chosen folks:
harvesthq/chosen#1379
They intentionally removed the chzn-done check in favor of the data attribute. So without a method to add data attributes to XML form fields, I'm stuck with a band-aid javascript solution.
It would be nice if we could get something like
#1620 merged so that extensions
can opt-in instead.
Matt Thomas
203.632.9322
http://betweenbrain.com/
Sent from mobile. Please pardon any typos or brevity.
On May 8, 2014 8:27 PM, "stutteringp0et" notifications@github.com wrote:
Just found this commit from the chosen folks:
harvesthq/chosen#1379 harvesthq/chosen#1379They intentionally removed the chzn-done check in favor of the data
attribute. So without a method to add data attributes to XML form fields,
I'm stuck with a band-aid javascript solution.—
Reply to this email directly or view it on GitHub#3274 (comment)
.
I can appreciate the auto-application of chosen. It keeps the interface consistent - but when we lose a feature like chzn-done and have no alternative, I get a little flustered.
I'd accept an option to add data attributes to XML fields - at least it would provide an avenue to the way "chosen" wants to handle it.
Status | New | ⇒ | Pending |
Labels |
Labels |
Removed:
?
|
Category | ⇒ | JavaScript |
Almost a year to the date but still valid. I have been checking this and getting data attributes into the XML forms needs some serious thinking. As @stutteringp0et already said, we already modified the chosen library, this change is not going to make it worse as it is.
Sure, we shouldn't be modifying external libraries but here it already happened. Having tested the latest version of Chozen it is unusable at the moment. So with both the new version not being usable and adding data attributes to XMLs not an easy fix, I suggest we merge as it is.
@roland-d +1 to merge this.
I'm currently working on the color picker, and since 3.2.3, the simple color picker introduced in core by @nonumber is broken (#807)
In the PR i'm working on, i have added to select a data-chosen="true" attribute which solves the issue with picket input, but until my PR will be committed, @w00fz 's PR fixes the simple color picker too! ;-)
Error
The patch could not be applied because the repository is missing
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-08-21 13:07:52 |
Closed_By | ⇒ | roland-d |
Closing this in favour of #7736 which has an active repo.
Possible duplicate of #1620