Feeling Lucky
?
?
[#3276] - Update TagManager0001Test.php
- Closed
- 11 Mar 2014
- Medium
- Build: staging
- # 3276
- Diff
- kshitijSharma2014:staging
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
I have commented the line 137 as its was responsible for a failure. It was checking that every time a tag was added its row number should be one but that's not necessary as if there exited some tags already then its row number would be accordingly as it should be but not 1.
Right Now i have commented it, it can also be removed.
javigomez
- comment
- 11 Mar 2014
Thanks for the pull @kshitijSharma2014,
I agree with @puneet0191 suggestion. I'm going to close this pull since I guess it will be easy for you to redo it and send a new one.
| Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-03-11 14:43:01 |
| Labels | |||
@kshitijSharma2014, I think commenting it won't be a solution..a better way to handle this would be to create a function such as searchTag, which returns true or false if the Tag is created and then call this function in assertTrue to verify tag creation.
Good Observation :)