Feeling Lucky
?
[#32727] - Temp#30018
- Closed
- 18 Mar 2021
- Medium
- Build: 4.0-dev
- # 32727
- Diff
- NikitaEmberi:temp#30018
User tests: Successful: Unsuccessful:
Pull Request for Issue # 30018
Summary of Changes
Changed fontawesome.min.css by removing :
- .icon-download::before{
content: " "
}
-.icon-list::before{
content: " "
}
-.icon-share-alt::before{
content:" "
}
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Repository Administration |
NikitaEmberi
- comment
- 18 Mar 2021
I cloned joomla-3 and in the process of updating to joomla-4 it happened. I'll try again.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-03-18 07:58:24 |
| Closed_By | ⇒ | NikitaEmberi | |
| Labels |
Added:
?
|
||
drmenzelit
- comment
- 18 Mar 2021
That is not the right way, you should clone Joomla and checkout the 4.0 branch
infograf768
- comment
- 18 Mar 2021
In any case, as @drmenzelit said, the solution proposed would have unwanted effects.
See a solution here
#30018 (comment)
NikitaEmberi
- comment
- 18 Mar 2021
So @infograf768 sir I have to clone install-from-web-server repository, make changes there and open a pull request on "install-from-web-server" repository right?
@NikitaEmberi I think something went wrong with your PR, it is showing more then 5.000(!) changed files, that is impossible to check. Please try again and check that only the really modified files are being committed.
If you remove the content from the icons that would probably affect other parts of Joomla, where these icons are being used.