User tests: Successful: Unsuccessful:
Pull Request for Issue #31909.
Content > Article
create a new article
click on cms-content dropdown select image
Click on any image additional data should popup
added a different background color and also added padding and border-radius which i thinks looks good
This should make the necessary changes required for the desired styling
Status | New | ⇒ | Pending |
Category | ⇒ | Repository NPM Change |
Can you please also style the summary element (to look like a button or an accordion header)?
Labels |
Added:
NPM Resource Changed
?
|
Category | Repository NPM Change | ⇒ | Administration Templates (admin) NPM Change Repository |
The css files should not be commited
@hitesh-coder sorry your changes need to be applied only on this file https://github.com/joomla/joomla-cms/blob/4.0-dev/build/media_source/system/css/fields/joomla-image-select.css
@dgrammatiko but you asked to change summary element as accordion header and that should be done in respective file
so should i now revert all my changes and apply as before
@hitesh-coder the problem is that your change is global and not just on this one element
Category | Repository NPM Change Administration Templates (admin) | ⇒ | Repository NPM Change |
Category | Repository NPM Change | ⇒ | Administration Templates (admin) NPM Change Repository |
Category | Repository NPM Change Administration Templates (admin) | ⇒ | Repository NPM Change |
Category | Repository NPM Change | ⇒ | Administration Templates (admin) NPM Change Repository |
Category | Repository NPM Change Administration Templates (admin) | ⇒ | Repository NPM Change |
I have tested this item
Better with this styling. Should it have a border?
I have not tested this item.
I tried to Test this, but when I Apply Patch, I can't see any change.
@meinhoonharsh you can't test this using the patch tester, because the PR changes a scss file and for this you need to run npm run build:css to work
add a border
joomla-field-mediamore details {
position: absolute;
background: #f5f5f5;
border-radius: .25rem;
border: 1px solid #c9c9c9; // add this
}
to get
@meinhoonharsh you can't test this using the patch tester, because the PR changes a scss file and for this you need to run npm run build:css to work
Thank You @drmenzelit , I will make sure to do this from now
hey @meinhoonharsh I have also added a border in my latest commit
I have tested this item
Yes - really nice with a border!
I have tested this item
I have Successfully tested this. It looks good in order to comparision with previous one
Status | Pending | ⇒ | Ready to Commit |
RTC
Status | Ready to Commit | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-03-31 11:45:59 |
Closed_By | ⇒ | hitesh-coder | |
Labels |
Added:
?
|
@hitesh-coder why did you close this PR?
@drmenzelit I mistakenly deleted the branch while exploring GitHub feature. can I make another PR?
@hitesh-coder No need to make a new PR. I've re-opened this so it can be merged. This can be done even when you branch was deleted, as far as I know.
Status | Closed | ⇒ | New |
Closed_Date | 2021-03-31 11:45:59 | ⇒ | |
Closed_By | hitesh-coder | ⇒ |
Status | New | ⇒ | Pending |
Thanks!
Status | Pending | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-03-31 15:09:20 |
Closed_By | ⇒ | drmenzelit | |
Labels |
Removed:
?
|
Please post screenshots Before and After pr.