NPM Resource Changed ? Pending

User tests: Successful: Unsuccessful:

avatar hitesh-coder
hitesh-coder
18 Mar 2021

Pull Request for Issue #31909.

Steps to reproduce

Content > Article
create a new article
click on cms-content dropdown select image
Click on any image additional data should popup

Summary of Changes

added a different background color and also added padding and border-radius which i thinks looks good

Expected result AFTER applying this Pull Request

This should make the necessary changes required for the desired styling

avatar hitesh-coder hitesh-coder - open - 18 Mar 2021
avatar hitesh-coder hitesh-coder - change - 18 Mar 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 18 Mar 2021
Category Repository NPM Change
avatar infograf768
infograf768 - comment - 18 Mar 2021

Please post screenshots Before and After pr.

avatar hitesh-coder
hitesh-coder - comment - 18 Mar 2021

Before

Screenshot 2021-03-18 at 5 59 36 PM

After

Screenshot 2021-03-18 at 4 11 41 PM

@infograf768

avatar dgrammatiko
dgrammatiko - comment - 18 Mar 2021

Can you please also style the summary element (to look like a button or an accordion header)?

avatar hitesh-coder hitesh-coder - change - 19 Mar 2021
Labels Added: NPM Resource Changed ?
avatar joomla-cms-bot joomla-cms-bot - change - 19 Mar 2021
Category Repository NPM Change Administration Templates (admin) NPM Change Repository
avatar hitesh-coder
hitesh-coder - comment - 19 Mar 2021

Updated as you asked @dgrammatiko

#BEFORE
Before

#AFTER
Screenshot 2021-03-19 at 3 26 28 PM

avatar drmenzelit
drmenzelit - comment - 19 Mar 2021

Can you use the same border-radius as in other places on template?

You have to check your PR, there are more changed files as needed. And the tests are failing (you can click on "Details" to see what is causing the problem)
grafik

avatar drmenzelit
drmenzelit - comment - 19 Mar 2021

The css files should not be commited

avatar dgrammatiko
dgrammatiko - comment - 19 Mar 2021
avatar hitesh-coder
hitesh-coder - comment - 19 Mar 2021

@dgrammatiko but you asked to change summary element as accordion header and that should be done in respective file
so should i now revert all my changes and apply as before

avatar brianteeman
brianteeman - comment - 19 Mar 2021

@hitesh-coder the problem is that your change is global and not just on this one element

avatar joomla-cms-bot joomla-cms-bot - change - 19 Mar 2021
Category Repository NPM Change Administration Templates (admin) Repository NPM Change
avatar hitesh-coder
hitesh-coder - comment - 19 Mar 2021

AFTER

Screenshot 2021-03-19 at 7 50 16 PM

avatar joomla-cms-bot joomla-cms-bot - change - 22 Mar 2021
Category Repository NPM Change Administration Templates (admin) NPM Change Repository
avatar joomla-cms-bot joomla-cms-bot - change - 22 Mar 2021
Category Repository NPM Change Administration Templates (admin) Repository NPM Change
avatar joomla-cms-bot joomla-cms-bot - change - 22 Mar 2021
Category Repository NPM Change Administration Templates (admin) NPM Change Repository
avatar joomla-cms-bot joomla-cms-bot - change - 22 Mar 2021
Category Repository NPM Change Administration Templates (admin) Repository NPM Change
avatar hitesh-coder hitesh-coder - change - 26 Mar 2021
The description was changed
avatar hitesh-coder hitesh-coder - edited - 26 Mar 2021
avatar ceford ceford - test_item - 28 Mar 2021 - Tested successfully
avatar ceford
ceford - comment - 28 Mar 2021

I have tested this item successfully on b5f790a

Better with this styling. Should it have a border?


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32728.

avatar meinhoonharsh meinhoonharsh - test_item - 29 Mar 2021 - Not tested
avatar meinhoonharsh
meinhoonharsh - comment - 29 Mar 2021

I have not tested this item.

I tried to Test this, but when I Apply Patch, I can't see any change.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32728.

avatar drmenzelit
drmenzelit - comment - 29 Mar 2021

@meinhoonharsh you can't test this using the patch tester, because the PR changes a scss file and for this you need to run npm run build:css to work

avatar hitesh-coder
hitesh-coder - comment - 29 Mar 2021

hey @ceford thanks for testing but could you please elaborate on the thing you mention I would love to make it better

avatar infograf768
infograf768 - comment - 29 Mar 2021

@hitesh-coder

add a border

joomla-field-mediamore details {
    position: absolute;
    background: #f5f5f5;
    border-radius: .25rem;
    border: 1px solid #c9c9c9; // add this
}

to get

Screen Shot 2021-03-29 at 09 14 35

avatar meinhoonharsh
meinhoonharsh - comment - 29 Mar 2021

@meinhoonharsh you can't test this using the patch tester, because the PR changes a scss file and for this you need to run npm run build:css to work

Thank You @drmenzelit , I will make sure to do this from now

avatar meinhoonharsh
meinhoonharsh - comment - 29 Mar 2021

I have tested this item successfully on b5f790a

Before:

image

After:

image

avatar hitesh-coder
hitesh-coder - comment - 29 Mar 2021

hey @meinhoonharsh I have also added a border in my latest commit

avatar ceford ceford - test_item - 29 Mar 2021 - Tested successfully
avatar ceford
ceford - comment - 29 Mar 2021

I have tested this item successfully on 934c082

Yes - really nice with a border!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32728.

avatar meinhoonharsh meinhoonharsh - test_item - 29 Mar 2021 - Tested successfully
avatar meinhoonharsh
meinhoonharsh - comment - 29 Mar 2021

I have tested this item successfully on 934c082

I have Successfully tested this. It looks good in order to comparision with previous one


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32728.
avatar infograf768 infograf768 - change - 30 Mar 2021
Status Pending Ready to Commit
avatar infograf768
infograf768 - comment - 30 Mar 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32728.

avatar hitesh-coder hitesh-coder - change - 31 Mar 2021
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2021-03-31 11:45:59
Closed_By hitesh-coder
Labels Added: ?
avatar hitesh-coder hitesh-coder - close - 31 Mar 2021
avatar drmenzelit
drmenzelit - comment - 31 Mar 2021

@hitesh-coder why did you close this PR?

avatar hitesh-coder
hitesh-coder - comment - 31 Mar 2021

@drmenzelit I mistakenly deleted the branch while exploring GitHub feature. can I make another PR?

avatar richard67
richard67 - comment - 31 Mar 2021

@hitesh-coder No need to make a new PR. I've re-opened this so it can be merged. This can be done even when you branch was deleted, as far as I know.

avatar richard67 richard67 - change - 31 Mar 2021
Status Closed New
Closed_Date 2021-03-31 11:45:59
Closed_By hitesh-coder
avatar richard67 richard67 - change - 31 Mar 2021
Status New Pending
avatar richard67 richard67 - reopen - 31 Mar 2021
avatar drmenzelit drmenzelit - close - 31 Mar 2021
avatar drmenzelit drmenzelit - merge - 31 Mar 2021
avatar drmenzelit
drmenzelit - comment - 31 Mar 2021

Thanks!

avatar drmenzelit drmenzelit - change - 31 Mar 2021
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-03-31 15:09:20
Closed_By drmenzelit
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment