[#32726] - Update _header.scss
- Fixed in Code Base
- 22 Mar 2021
- Medium
- Build: 4.0-dev
- # 32726
- Diff
- srishty-07:patch-2
User tests: Successful: Unsuccessful:
Pull Request for Issue #32711
Summary of Changes
background color of the icons in navbar on hover is changed from var(--atum-bg-dark) to var(--atum-bg-dark-40)
Testing Instructions
Open the Joomla backend , and in the navbar on the top hover on any icon , hover effect is almost invisible
Actual result BEFORE applying this Pull Request
- before hover :
- on hover :
Expected result AFTER applying this Pull Request
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Templates (admin) NPM Change |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32726.
Preferably, do it as below extending to the edge vertically so the text doesn't touch the bottom.
@srishty-07 I understand. If it can be tweaked as suggested, then it would be ideal.
@srishty-07 I understand. If it can be tweaked as suggested, then it would be ideal.
Sure @Quy i'll try that
| Labels |
Added:
NPM Resource Changed
?
|
||
@srishty-07 can you please check your code style? Style linter is failing
It is better, but the icon is distorted/stretched vertically.
It is better, but the icon is distorted/stretched vertically.
yes, scaling should be same for both x and y axis to avoid that.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32726.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32726.
I know what you are trying to do, but transform: scale is not the best solution. We should stay consistent in the template, in no other place we zoom the icons on hover.
I know what you are trying to do, but
transform: scaleis not the best solution. We should stay consistent in the template, in no other place we zoom the icons on hover.
@drmenzelit ma'am the first PR do not show any scaling should I revert the recent changes if it is fine, it is looking good also.
| Labels |
Added:
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32726.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32726.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32726.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-03-22 16:12:41 |
| Closed_By | ⇒ | drmenzelit | |
| Labels |
Added:
?
Removed: ? |
||
Thanks and congratulations to your first merged PR
I have tested this item✅ successfully on 607c451
Looks nice for me.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32726.