Joomla! Issue Tracker | Joomla! CMS #32725 - [4] Code cosmetic. com

ReLater
18 Mar 2021

See https://github.com/joomla/joomla-cms/blob/4.0.0-beta7/components/com_content/tmpl/article/default.php#L43
- && $this->item->pagination can be removed. "If it's not empty then it is and we don't have to check again if it is."
See https://github.com/joomla/joomla-cms/blob/4.0.0-beta7/components/com_content/tmpl/article/default.php#L49-L51
- Remove comment or does anybody understand what we can group here and how?
- Opening ( and closing ) brackets around the whole OR block can be removed.

ReLater - open - 18 Mar 2021

joomla-cms-bot - change - 18 Mar 2021

Labels

Added: ?

joomla-cms-bot - labeled - 18 Mar 2021

ReLater - change - 18 Mar 2021

The description was changed

ReLater - edited - 18 Mar 2021

rdeutz - comment - 18 Mar 2021

If it's not empty then it is and we don't have to check again if it is.

agreed

Remove comment or does anybody understand what we can group here and how?

I think it's there from an older version, can be removed

Opening ( and closing ) brackets around the whole OR block can be removed.

agreed

Can you make a PR?

ReLater - comment - 18 Mar 2021

I'll do when I find time. Maybe some days... Against which branch?

rdeutz - comment - 18 Mar 2021

Against which branch?

4.0-dev

saumyasarkar11 - comment - 19 Mar 2021

Against which branch?

4.0-dev

I have made the requested PR

drmenzelit - comment - 19 Mar 2021

Closing as we have a PR #32746

drmenzelit - close - 19 Mar 2021

drmenzelit - change - 19 Mar 2021

Joomla! Issue Tracker - CMS