? Pending

User tests: Successful: Unsuccessful:

avatar sksuryan
sksuryan
14 Mar 2021

Pull Request for Issue #32679 .

Summary of Changes

This PR fixes the issue where the table in Mailing templates would fail to be responsive because of long IDs since they are treated as a single word, causing an overflow. Hence, to fix this problem, text-break class for ID column has been added.

Further, this PR tweaks alignment of text in Mail templates table to visually make it better.

Testing Instructions

  • Login to Administrator.
  • Go to System > Mail Templates.
  • Use Dev tools to resize the window. The overflow could be seen at around 1024px.

Actual result BEFORE applying this Pull Request

image
image

Expected result AFTER applying this Pull Request

The table should be responsive and be able to adapt to smaller widths.

image

avatar sksuryan sksuryan - open - 14 Mar 2021
avatar sksuryan sksuryan - change - 14 Mar 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 14 Mar 2021
Category Administration
avatar ChristineWk ChristineWk - test_item - 14 Mar 2021 - Tested successfully
avatar ChristineWk
ChristineWk - comment - 14 Mar 2021

I have tested this item successfully on a281a03


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32689.

avatar sksuryan sksuryan - change - 14 Mar 2021
Labels Added: ?
avatar toivo toivo - test_item - 14 Mar 2021 - Tested successfully
avatar toivo
toivo - comment - 14 Mar 2021

I have tested this item successfully on 23a0260

Tested successfully in Beta8-dev of 14 March on Wampserver 3.2.4 using PHP 8.0.2.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32689.

avatar ChristineWk ChristineWk - test_item - 14 Mar 2021 - Tested successfully
avatar ChristineWk
ChristineWk - comment - 14 Mar 2021

I have tested this item successfully on 23a0260


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32689.

avatar chmst chmst - change - 14 Mar 2021
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-03-14 22:25:07
Closed_By chmst
avatar chmst chmst - close - 14 Mar 2021
avatar chmst chmst - merge - 14 Mar 2021
avatar chmst
chmst - comment - 14 Mar 2021

Thanks!

avatar sksuryan
sksuryan - comment - 15 Mar 2021

Welcome!

Add a Comment

Login with GitHub to post a comment