[#32688] - [4.0] Fixes button margin
- Closed
- 15 Mar 2021
- Medium
- Build: 4.0-dev
- # 32688
- Diff
- srishty-07:4.0-dev
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
bootstrap margin class was added to the danger button
Testing Instructions
- open the cassiopeia page[frontend] on (http://localhost/joomla-cms/index.php?option=com_config&view=modules&id=1&Itemid=101&return=aHR0cDovL2xvY2FsaG9zdC9qb29tbGEtY21zLw%3D%3D)
2)open edit module on the right hand side of the page.
- set the toggle device toolbar to mobile view.
4)before applying the patch it would show improper margin between the buttons, but after applying the patch proper margin is there.
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End com_config |
Agree it would be better to do it in (s)css.
@srishty-07 Let us know if you need advise on which scss file to modify.
| Title |
|
||||||
@brianteeman @richard67 sir I thought of doing that , but as every button needed margin so just added bootstrap margin to it, but if you say so I will add media queries in scss file. @richard67 it will be really kind of you if you please tell me about which scss file I have to make changes in.
@richard67 it will be really kind of you if you please tell me about which scss file I have to make changes in.
I have no idea myself right now
The definitions for buttons in Cassiopeia are located in templates/cassiopeia/scss/vendor/bootstrap/_buttons.scss
Be careful, because changes here will change all buttons in the template, so you have to check the whole frontend to avoid side effects.
After doing changes in the scss file(s) you need to run npm run build:css
| Labels |
Added:
?
|
||
| Category | Front End com_config | ⇒ | Front End Templates (site) NPM Change |
| Labels |
Added:
NPM Resource Changed
|
||
it would better adding margin using css
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32688.
@vyaki1718 i have made the changes in css only in 2nd pr.
In Article Edit view the Versions button needs attention too. Perhaps not in English but in any language where the button labels are longer.
So I wonder if the style should be added to the btn class rather than the individual btn-xxx classes.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32688.
So I wonder if the style should be added to the btn class rather than the individual btn-xxx classes.
That is exactly how it should have been done as its more robust code as you just discovered.
Also please use rem and not px
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-03-15 18:41:22 |
| Closed_By | ⇒ | srishty-07 |
Would it not be better to do this in css with a media query by adding a margin-bottom to the .btn class