[#32687] - [4.0] Fix filters not translated for com_mails
- Fixed in Code Base
- 14 Mar 2021
- Medium
- Build: 4.0-dev
- # 32687
- Diff
- joomdonation:fix_mail_templates_translation
User tests: Successful: Unsuccessful:
Pull Request for Issue #32675.
Summary of Changes
This PR loads language files for not only components but also for plugins (borrow some code from ActionlogsHelper for loading translation) to make sure filters translated properly for com_mails component.
Testing Instructions
- See #32675 , confirm the issue
- Apply patch, confirm that the issue is fixed.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration |
| Labels |
Added:
?
|
||
I've restored the previous test result in the issue tracker since the commit which invalidated the test was just a code style change.
@joomdonation It seems my suggestion contained a few code style errors: https://ci.joomla.org/joomla/joomla-cms/40686/1/6 ;-)
Ah, no, wasn't me, was the change before that, too.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32687.
| Title |
|
||||||
@brianteeman Could you repeat your test? Thanks in advance.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32687.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32687.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-03-14 22:15:51 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
Thanks!
I have tested this item✅ successfully on 47d0e6d
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32687.