NPM Resource Changed ? ? Pending

User tests: Successful: Unsuccessful:

avatar dgrammatiko
dgrammatiko
14 Mar 2021

Pull Request for Issue # .

Summary of Changes

Nodejs v10 goes EOL on April 30th.
This PR raises the requirement to v12

Also added the minimum version for PHP, node, npm as badges in the readme

Screenshot 2021-03-14 at 16 51 44

Testing Instructions

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Documentation Changes Required

The docs for setting up the dev environment should also mention the minimum nodejs version as 12, eg here:

https://docs.joomla.org/J4.x:Setting_Up_Your_Local_Environment

avatar dgrammatiko dgrammatiko - open - 14 Mar 2021
avatar dgrammatiko dgrammatiko - change - 14 Mar 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 14 Mar 2021
Category NPM Change
avatar dgrammatiko dgrammatiko - change - 14 Mar 2021
Labels Added: NPM Resource Changed ?
avatar joomla-cms-bot joomla-cms-bot - change - 14 Mar 2021
Category NPM Change Repository NPM Change
avatar richard67 richard67 - change - 14 Mar 2021
The description was changed
avatar richard67 richard67 - edited - 14 Mar 2021
avatar richard67
richard67 - comment - 14 Mar 2021

@dgrammatiko Your description should mention the additional build status badges in the readme.

avatar dgrammatiko dgrammatiko - change - 14 Mar 2021
The description was changed
avatar dgrammatiko dgrammatiko - edited - 14 Mar 2021
avatar dgrammatiko
dgrammatiko - comment - 14 Mar 2021

@richard67 done

avatar richard67 richard67 - test_item - 14 Mar 2021 - Tested successfully
avatar richard67
richard67 - comment - 14 Mar 2021

I have tested this item successfully on a3afab1

Code review + checked that CI is successful + checked the new badges at https://github.com/dgrammatiko/joomla-cms/tree/patch-13 .


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32690.

avatar alikon alikon - test_item - 14 Mar 2021 - Tested successfully
avatar alikon
alikon - comment - 14 Mar 2021

I have tested this item successfully on a3afab1


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32690.

avatar alikon alikon - change - 14 Mar 2021
Status Pending Ready to Commit
avatar alikon
alikon - comment - 14 Mar 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32690.

avatar wilsonge wilsonge - change - 14 Mar 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-03-14 22:13:07
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 14 Mar 2021
avatar wilsonge wilsonge - merge - 14 Mar 2021
avatar wilsonge
wilsonge - comment - 14 Mar 2021

Thanks!

Add a Comment

Login with GitHub to post a comment