Feeling Lucky
NPM Resource Changed
?
?
[#32690] - Drop Nodejs v10
- Fixed in Code Base
- 14 Mar 2021
- Medium
- Build: 4.0-dev
- # 32690
- Diff
- dgrammatiko:patch-13
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
Nodejs v10 goes EOL on April 30th.
This PR raises the requirement to v12
Also added the minimum version for PHP, node, npm as badges in the readme
Testing Instructions
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Documentation Changes Required
The docs for setting up the dev environment should also mention the minimum nodejs version as 12, eg here:
https://docs.joomla.org/J4.x:Setting_Up_Your_Local_Environment
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | NPM Change |
| Labels |
Added:
NPM Resource Changed
?
|
||
| Category | NPM Change | ⇒ | Repository NPM Change |
dgrammatiko
- comment
- 14 Mar 2021
@richard67 done
richard67
- comment
- 14 Mar 2021
I have tested this item
Code review + checked that CI is successful + checked the new badges at https://github.com/dgrammatiko/joomla-cms/tree/patch-13 .
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32690.
alikon
- comment
- 14 Mar 2021
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32690.
| Status | Pending | ⇒ | Ready to Commit |
alikon
- comment
- 14 Mar 2021
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32690.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-03-14 22:13:07 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
wilsonge
- comment
- 14 Mar 2021
Thanks!
@dgrammatiko Your description should mention the additional build status badges in the readme.