Feeling Lucky
?
[#32639] - Update search.php
- Closed
- 12 Mar 2021
- Medium
- Build: staging
- # 32639
- Diff
- saumyasarkar11:patch-3
User tests: Successful: Unsuccessful:
Pull Request for Issue #32319 .
Summary of Changes
Line 268 has been changed....
From: return preg_replace("/"^/ui", '\1', $str);
To: return $str;
Testing Instructions
Search a string with single/double quotes.
Let us consider it to be: My Friend's Pencil
Actual result BEFORE applying this Pull Request
My Friend's Penci
Expected result AFTER applying this Pull Request
My Friend's Pencil
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_search |
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-03-11 05:55:43 |
| Closed_By | ⇒ | saumyasarkar11 | |
| Labels |
Added:
?
|
||
| Status | Closed | ⇒ | New |
| Closed_Date | 2021-03-11 05:55:43 | ⇒ | |
| Closed_By | saumyasarkar11 | ⇒ |
| Status | New | ⇒ | Pending |
richard67
- comment
- 12 Mar 2021
@saumyasarkar11 Now I found your other PR #32637 for the same issue with a different fix at the same place. Am confused. Which PR is the right one and which one shall be closed?
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-03-12 16:52:23 |
| Closed_By | ⇒ | saumyasarkar11 |
@saumyasarkar11 Could you change the title of this pull request (PR) to something more meaningful, e.g. "Fix missing character in search result title"? I know, the current title "Update search.php" is what GitHub had suggested, but that should be changed so people can easily see by the title what this PR is good for. Thanks in advance.