[#32640] - [4.0] fixes Cassiopeia footer not being responsive
- Fixed in Code Base
- 11 Mar 2021
- Medium
- Build: 4.0-dev
- # 32640
- Diff
- sksuryan:footer_not_responsive_fix
User tests: Successful: Unsuccessful:
Pull Request for Issue #32553 .
Summary of Changes
This pull request addresses the issue where the footer isn't responsive in mobile view for Cassiopeia when there's more than one module in footer, by adding a media query in _footer.scss to change the flex-direction to column and to add margins of 6px in y direction for adequate spacing.
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Templates (site) NPM Change |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32640.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32640.
Looking at the complete file and not only at the change of this PR, I see that we have one padding value given in rem in that file here:
With this PR we will then have a margin given in px in the same file.
That seems to be inconsistent to me.
Wouldn't it be better to define the new margin also in rem?
Just asking. I might be wrong.
| Status | Ready to Commit | ⇒ | Pending |
Back to pending, @sksuryan could you replace the margin, please?
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32640.
| Labels |
Added:
NPM Resource Changed
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32640.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32640.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32640.
bembelimen
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-03-11 16:12:20 |
| Closed_By | ⇒ | bembelimen | |
| Labels |
Added:
?
|
||
@bembelimen hopefully you'll be seeing and closing more PRs(after successful merges ofcourse) by me soon!
I have tested this item✅ successfully on f198ff3
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32640.