[#32638] - Display proper search results
- Closed
- 12 Apr 2021
- Medium
- Build: staging
- # 32638
- Diff
- saumyasarkar11:patch-2
User tests: Successful: Unsuccessful:
Pull Request for Issue #32115 .
Summary of Changes
Starting index of search changed from $length to $wordpos on line 350.
Testing Instructions
Add an article and search for any keyword you had added to its title or description.
Actual result BEFORE applying this Pull Request
Fatal error: mb_strpos(): Argument #3 ($offset) must be contained in argument #1 ($haystack)
Expected result AFTER applying this Pull Request
Proper search results appear with listing filters.
Documentation Changes Required
No documentation changes required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_search |
| Title |
|
||||||
See #32638 (comment)
Steps:
-
Installed Joomla_3.9.26-dev-Development-Full_Package.zip (Friday, 12 March 2021 03:00:04 UTC)
-
Environment Xampp PHP 8.0.2.
-
Installed German language.
-
No demo data.
-
Created a com_search menu item
-
Applied patch 32638
-
Created an article. Title:
Modulpositionen mit Bootstrap 2 ausrichten - Die magische Zwölf -
The HTML of editor text is here editor-html.zip . Just paste it in editor (HTML view).
-
Save article
-
Go to frontend and search for
modulstil -
Output on search page (see image 1). Errors:
-
- Title is cut
-
- Search result text is too long.
-
Compared it with a site where more articles exist (see image 2). Errors:
-
- All titles of all hits are cut.
-
- Same error with the article above.
-
How it should look like: See image 3.
Images
Image 1
Image 2
Image 3
When I use this ugly hack (not really knowing what I do) the output on search page seems to be OK. Therefore I think we need somewhere somehow a corrective calculation of the passed over $length. But ????? Because PHP messages are suppressed by the @ in PHP 7, maybe the creator of this method knew already that it works incorrectly under some circumstances?
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-03-12 16:50:44 |
| Closed_By | ⇒ | saumyasarkar11 | |
| Labels |
Added:
?
|
||
Will look into it. Thanks for the feedback.
| Status | Closed | ⇒ | New |
| Closed_Date | 2021-03-12 16:50:44 | ⇒ | |
| Closed_By | saumyasarkar11 | ⇒ |
| Status | New | ⇒ | Pending |
Another and better hack that also works if more than just 1 german Umlaut in headline:
@HLeithner Can you give a comment. See also issue #32115 TBH I don't understand the whole code in search.php ;-)
| Title |
|
||||||
Hello @saumyasarkar11 ! Any news here? I'm just pushing a bit because the issue is a "real bug".
Hello @saumyasarkar11 ! Any news here? I'm just pushing a bit because the issue is a "real bug".
Go ahead...I am staying a bit busy with other things now....Go ahead...its a real bug...needs to be fixed quickly
@saumyasarkar11
Please close this pr. Has been replaced by #33113
HLeithner
- | Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-04-12 14:11:29 |
| Closed_By | ⇒ | HLeithner | |
| Labels |
Added:
?
|
||
I have tested this item? unsuccessfully on 3ed7e7b
Description of unsuccessful test will follow on Github.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32638.