[#32574] - [4.1] Proper cache invalidation for css urls
- Closed
- 3 Feb 2022
- Medium
- Build: 4.1-dev
- # 32574
- Diff
- dgrammatiko:4.0-dev-version-scss-urls
User tests: Successful: Unsuccessful:
Pull Request for Issue #32573 (partially) .
Summary of Changes
- Adds one more PostCSS plugin https://www.npmjs.com/package/postcss-url-version
- Adjust the 2 scripts to use the above plugin
Testing Instructions
Make a copy of the media and also the css folder of cassiopeia, atum and installtion
On this PR's code you need to run npm install
Then compare the produced css with the one you've backup before for example: search for url(, The new css files should have someting like ?v=13423-random-alphanumeric at the end (only for local images/fonts)
Actual result BEFORE applying this Pull Request
Urls don;t have a hash
Expected result AFTER applying this Pull Request
Urls have a hash
Documentation Changes Required
No
One comment here, although at the original issue I mentioned another plugin there were bugs and also it's abandoned for some years. (I didn't either wanted to write a plugin, ok less than 100locs, but still)
@wilsonge is this ok for 4.0.x or should I rebase it to 4.0.x?
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Repository NPM Change |
| Labels |
Added:
NPM Resource Changed
?
|
||
| Labels |
Added:
Conflicting Files
|
||
| Category | JavaScript Repository NPM Change | ⇒ | Repository Administration com_admin SQL Postgresql com_config com_contact com_content com_fields com_installer com_menus com_modules com_newsfeeds com_users com_workflow Language & Strings |
| Labels |
Added:
?
Removed: NPM Resource Changed |
||
| Category | Repository Administration com_admin SQL Postgresql com_config com_contact com_content com_fields com_installer com_menus com_modules com_newsfeeds com_users com_workflow Language & Strings | ⇒ | JavaScript Repository NPM Change |
| Labels |
Added:
NPM Resource Changed
Removed: ? |
||
I have tested this item
First of all
Hey, it's cool that you developed the plugin "postcss-url-version" yourself and have now integrated it into Joomla.
That's how I tested it
I cloned your project and installed it. Then I went through various css files and also checked whether the version number changes depending on the URL.
These files were checked
fontawesome.min.css
template.min.css (in the "Home Dashboard" view)
Result
The test was successful, I did not notice any problems during the test.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32574.
I have tested this item
Checked all css files. Hash values were applied correctly.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32574.
@dgrammatiko We have again a conflict here in the package-lock.json.
| Labels |
Added:
?
Removed: Conflicting Files ? |
||
| Labels |
Added:
?
Removed: ? |
||
@bembelimen something for 4.1?
Yes, if we get the two tests, for sure it's something for 4.1
| Category | Repository JavaScript NPM Change | ⇒ | Unit Tests Repository Administration com_content com_finder com_tags com_users Language & Strings Modules |
| Title |
|
||||||
| Category | Repository Unit Tests Administration com_content com_finder com_tags com_users Language & Strings Modules | ⇒ | JavaScript Repository NPM Change |
@bembelimen I rebased on 4.1 and fixed the conflicts, this should be ready for testing again
| Labels |
Added:
?
Removed: ? |
||
| Build | 4.0-dev | ⇒ | 4.1-dev |
@bembelimen is there any chance to get this for 4.1?
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-02-03 15:23:33 |
| Closed_By | ⇒ | dgrammatiko |
@dgrammatiko it's still valid for 4.1(.1), we just need some tests, probably the @joomla/bug-squad can help with it?
I will re open this after the 4.1 release
please fix conflict