Labels |
Added:
?
|
hm, joomla-alert.css should have a version, same as joomla-alert.js, need to look
joomla-alert.css should have a version
well, it have, but some files is doubled on your screenshot, same for color_standart.css
Core assets (and other with undefined version property) contains "media version hash"
Shouldn't every file that is in the user editable area eg /templates have a full hash
Shouldn't every file that is in the user editable area eg /templates have a full hash
that what I meant, they will have a hash, unless the asset have a specified "version" property https://github.com/joomla/schemas/blob/6f1d84553cff3ff050c29f4c19f58b63bd483ae8/json-schema/web_assets.json#L41-L45
it like this:
1 version property does not exists (or set to auto
) => use hash, eg file.css?hash
2 version property is empty or set to false
=> no hash, no version query
3 version property has a version value => version value in query, eg file.css?version
case 1 is all core and custom assets, including /templates
case 3 all assets from /media/vendor
case 2 custom assets by someone, there no such in Joomla, but can be added by extensions
So in my screenshot the following are missing a hash
woff2 is a font file, it loaded by browser from parsing CSS, it depend how font-face defined in CSS files, not by Joomla
color-standard, joomla-alert
If you look on your screenshot you will see they are doubled in some reason, one with version and another without:
I not sure why, looks strange, does they also doubled in the page source HTML?
joomla-alert is not a double. one is in media and the other in the template
why they twice?
to me it looks wrong, can be a bug, need to check
joomla-alert is not a double. one is in media and the other in the template
I think this one is overridden, eg the template has a valid override of the original (in the media/vendor folder) file. Maybe that's a bug.
A few days ago I did this #32485 that creates a version hash per static asset (right now only js) which actually is derived from the actual content of the file. It should be way more efficient than invalidating EVERYTHING on each update
One more thing about the fonts, we're doing it WRONG, we need a plugin like https://www.npmjs.com/package/postcss-url-versioner I will do a PR (unless someone is faster here)
EDIT We also need a similar solution for images ( I mean the ones in a SRC attribute)
I will leave you guys to work out a solution. Not something I can help with. Sorry
@brianteeman here's the solution for the urls: #32574
about doubled joomla-alert, someone who familiar with styling should fix this
Just remove the .css
?
may be, may be, not sure why it is not included, something scss specific?
Works for me here
Status | New | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-08-10 07:24:42 |
Closed_By | ⇒ | brianteeman | |
Labels |
Added:
?
Removed: ? |
Resolved elsewhere
Yes, that correct, the assets from /media/vendor contains ?version
Core assets (and other with undefined version property) contains "media version hash"
The fonts does not contain anything because they loaded by CSS files.
upd: ref comment #22435 (comment)