NPM Resource Changed ? ?

Pending

User tests: Successful: Unsuccessful:

avatar Fedik
Fedik
20 Feb 2021

Summary of Changes

Redo of #32271 but without eval

Testing Instructions

Same as #32271

ping @wilsonge @dgrammatiko

avatar Fedik Fedik - open - 20 Feb 2021
avatar Fedik Fedik - change - 20 Feb 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 20 Feb 2021
Category JavaScript Repository NPM Change
avatar infograf768
infograf768 - comment - 20 Feb 2021

// This is UNSAFE!!!!

??

avatar Fedik
Fedik - comment - 20 Feb 2021

yes, it still unsafe, but not that as eval 😄

avatar dgrammatiko
dgrammatiko - comment - 20 Feb 2021

Ahuh I forgot to return 🤦‍♂️

avatar Fedik
Fedik - comment - 20 Feb 2021

yeap, return changes everything

avatar infograf768
infograf768 - comment - 20 Feb 2021

PR works fine here.

avatar dgrammatiko dgrammatiko - test_item - 20 Feb 2021 - Tested successfully
avatar dgrammatiko
dgrammatiko - comment - 20 Feb 2021

I have tested this item successfully on 2cf6946


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32469.

avatar richard67
richard67 - comment - 20 Feb 2021

PR works fine here.

@infograf768 So was that a good test? If yes, shall I set the test result for you?

avatar richard67 richard67 - test_item - 20 Feb 2021 - Not tested
avatar richard67
richard67 - comment - 20 Feb 2021

I have not tested this item.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32469.

avatar richard67 richard67 - test_item - 20 Feb 2021 - Tested successfully
avatar richard67
richard67 - comment - 20 Feb 2021

I have tested this item successfully on 2cf6946


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32469.

avatar richard67 richard67 - change - 20 Feb 2021
Status Pending Ready to Commit
Labels Added: ? NPM Resource Changed
avatar richard67
richard67 - comment - 20 Feb 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32469.

avatar wilsonge wilsonge - change - 20 Feb 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-02-20 14:35:33
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 20 Feb 2021
avatar wilsonge wilsonge - merge - 20 Feb 2021
avatar wilsonge
wilsonge - comment - 20 Feb 2021

Thanks!

Add a Comment

Login with GitHub to post a comment