Feeling Lucky
NPM Resource Changed
?
?
[#32469] - [4.0] Remove eval from modal.js
- Fixed in Code Base
- 20 Feb 2021
- Medium
- Build: 4.0-dev
- # 32469
- Diff
- Fedik:remove-eval-modal
User tests: Successful: Unsuccessful:
Summary of Changes
Redo of #32271 but without eval
Testing Instructions
Same as #32271
ping @wilsonge @dgrammatiko
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Repository NPM Change |
Fedik
- comment
- 20 Feb 2021
yes, it still unsafe, but not that as eval
dgrammatiko
- comment
- 20 Feb 2021
Ahuh I forgot to return
Fedik
- comment
- 20 Feb 2021
yeap, return changes everything
infograf768
- comment
- 20 Feb 2021
PR works fine here.
dgrammatiko
- comment
- 20 Feb 2021
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32469.
richard67
- comment
- 20 Feb 2021
PR works fine here.
@infograf768 So was that a good test? If yes, shall I set the test result for you?
richard67
- comment
- 20 Feb 2021
I have not tested this item.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32469.
richard67
- comment
- 20 Feb 2021
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32469.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
NPM Resource Changed
|
||
richard67
- comment
- 20 Feb 2021
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32469.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-02-20 14:35:33 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
wilsonge
- comment
- 20 Feb 2021
Thanks!
// This is UNSAFE!!!!??