Pending

User tests: Successful: Unsuccessful:

avatar joomdonation
joomdonation
20 Feb 2021

Pull Request for Issue #32117, #17812

Summary of Changes

Similar PR to #32468 but for staging.

This PR improves frontend article submission form so that the form will respect permission of the pre-selected category (which is selected in the menu item parameter). See #32117 to understand the issue better

Testing Instructions

  1. Create a new user account, assign the account to Author user group.
  2. Edit an existing article category (or create a new category), in the Permissions tab, make sure Edit State permission for Author user group is set to Allowed.
  3. Create a menu item to link to Create Article menu option.
  4. Login to frontend using the user account which belong to Author user group above, access to the menu item to try to submit article:
  • Before patch: You do not have Edit State permission, so you cannot change settings such as Published, Start Publishing, Start Featured....
  • After patch: You can select status for the article (for example Published), select date For Start Publishing, Start Featured.. (in Publish tab)
avatar joomdonation joomdonation - open - 20 Feb 2021
avatar joomdonation joomdonation - change - 20 Feb 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 20 Feb 2021
Category Administration com_content Front End
avatar toivo toivo - test_item - 21 Feb 2021 - Tested successfully
avatar toivo
toivo - comment - 21 Feb 2021

I have tested this item successfully on 718aac8

Tested successfully in 3.9.25-dev of 21 February in Wampserver 3.2.4 using Apache 2.4.46c, MySQL 8.0.23, PHP 8.0.2.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32470.

avatar Sieger66
Sieger66 - comment - 21 Feb 2021

But this patch works only if you Choose a Category in the Options-Tab of the Create_article_menu-item
at your "3. in your Testing Instructions".

If you set "Specific Category" to "No" in the Options-Tab of the Create_article_menu-item:

You furthermore, if you create new article, do not have Edit State permission, so you cannot change settings such as Published, Start Publishing, Start Featured....

avatar Sieger66 Sieger66 - test_item - 21 Feb 2021 - Tested successfully
avatar Sieger66
Sieger66 - comment - 21 Feb 2021

I have tested this item successfully on 718aac8


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32470.

avatar infograf768
infograf768 - comment - 22 Feb 2021

Note that this is similar to the 4.0 PR #32468 , but for 3.x
@HLeithner @wilsonge
Shall this be merged and then taken care of when pushed to 3.10 and then to 4.0 , i.e. closing #32468 ?

avatar infograf768 infograf768 - edited - 22 Feb 2021
avatar infograf768 infograf768 - change - 22 Feb 2021
Status Pending Ready to Commit
avatar infograf768
infograf768 - comment - 22 Feb 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32470.

avatar joomdonation
joomdonation - comment - 22 Feb 2021

@infograf768 The logic for getting $catId (the category the article is submitted to) is different in Joomla 3 and Joomla 4 (you can compare the changes in the two PRs, the PR for Joomla 4 requires less code changes in Joomla 3)

So this PR needs to be merged here, and then to 3.10. The PR for Joomla 4 should be merged, too, but when you merge this PR to Joomla 4, please use the code in Joomla 4 (in short, somehow, we need to ignore this PR when merge changes to Joomla 4)

avatar infograf768
infograf768 - comment - 22 Feb 2021

@joomdonation
I understand. But as I am not in charge of pushing stuff to 4.0 from 3.10, better let people who do be aware of this to avoid further errors. :)

Add a Comment

Login with GitHub to post a comment