NPM Resource Changed ? Pending

User tests: Successful: Unsuccessful:

avatar dgrammatiko
dgrammatiko
12 Feb 2021

Pull Request supplementary to #32379 .

Add missing change events for the fields media, user and simple color

Testing Instructions

in your browser console (assuming Chrome) Selecet the HTML element for the field (eg joomla-field-simple-color) and in the console copy paste $0.addEventListener('change', (ev) => console.log(ev)); Then select a color. Observe the console. Repeat for the other 2 fields

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Documentation Changes Required

avatar dgrammatiko dgrammatiko - open - 12 Feb 2021
avatar dgrammatiko dgrammatiko - change - 12 Feb 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 12 Feb 2021
Category JavaScript Repository NPM Change
avatar dgrammatiko dgrammatiko - change - 12 Feb 2021
Labels Added: NPM Resource Changed ?
avatar richard67
richard67 - comment - 12 Feb 2021

@dgrammatiko Don't forget to provide some testing instructions ?

avatar dgrammatiko dgrammatiko - change - 12 Feb 2021
The description was changed
avatar dgrammatiko dgrammatiko - edited - 12 Feb 2021
avatar laoneo laoneo - test_item - 12 Feb 2021 - Tested successfully
avatar laoneo
laoneo - comment - 12 Feb 2021

I have tested this item successfully on ad38213


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32397.

avatar laoneo
laoneo - comment - 12 Feb 2021

We have two successful tests here, see comment #32357 (comment).

avatar wilsonge wilsonge - change - 12 Feb 2021
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-02-12 16:07:01
Closed_By wilsonge
avatar wilsonge wilsonge - close - 12 Feb 2021
avatar wilsonge wilsonge - merge - 12 Feb 2021
avatar wilsonge
wilsonge - comment - 12 Feb 2021

Thanks!

Add a Comment

Login with GitHub to post a comment