? ? Pending

User tests: Successful: Unsuccessful:

avatar richard67
richard67
12 Feb 2021

Pull Request for Issue #32329 .

Summary of Changes

Use this.theForm.append(this.orderField); instead of this.theForm.innerHTML += this.orderField.outerHTML; to append the order field.

Thanks @skurvish for reporting the issue and suggesting the right fix.

Testing Instructions

Have an admin list view that does not have fullordering select list in it's search tools form, or remove that field from that form for some component.

E.g. for com_contacts, remove the following lines of code:

https://github.com/joomla/joomla-cms/blob/4.0-dev/administrator/components/com_contact/forms/filter_contacts.xml#L95-L125

In the list view of that component, try to apply some filter with search tools and try to use the clear button.

Enter some text into the text search box and then use the "Clear" button to clear the text search box.

Apply the patch of this pull request and then test again.

Note: It needs npm to compile the js after you have applied the patch, or you use the package built by drone for this PR.

Actual result BEFORE applying this Pull Request

Search tools "Filter Options" drop down doesn't work.

Filters or text searches are not cleared when using the "Clear" button.

Expected result AFTER applying this Pull Request

Everything works.

Documentation Changes Required

None.

avatar richard67 richard67 - open - 12 Feb 2021
avatar richard67 richard67 - change - 12 Feb 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 12 Feb 2021
Category JavaScript Repository NPM Change
avatar skurvish skurvish - test_item - 12 Feb 2021 - Tested successfully
avatar skurvish
skurvish - comment - 12 Feb 2021

I have tested this item successfully on 8c9c87d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32396.

avatar richard67 richard67 - change - 12 Feb 2021
The description was changed
avatar richard67 richard67 - edited - 12 Feb 2021
avatar richard67 richard67 - change - 12 Feb 2021
The description was changed
avatar richard67 richard67 - edited - 12 Feb 2021
avatar Quy Quy - test_item - 12 Feb 2021 - Tested successfully
avatar Quy
Quy - comment - 12 Feb 2021

I have tested this item successfully on 8c9c87d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32396.

avatar Quy Quy - change - 12 Feb 2021
Status Pending Ready to Commit
Labels Added: ?
avatar Quy
Quy - comment - 12 Feb 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32396.

avatar laoneo laoneo - change - 12 Feb 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-02-12 15:58:11
Closed_By laoneo
Labels Added: ?
avatar laoneo laoneo - close - 12 Feb 2021
avatar laoneo laoneo - merge - 12 Feb 2021
avatar laoneo
laoneo - comment - 12 Feb 2021

Thanks!

Add a Comment

Login with GitHub to post a comment