[#32371] - [4.0] [PHP 8] Fix PHP error "array_merge() does not accept unknown named parameters" for com_finder
- Fixed in Code Base
- 11 Feb 2021
- Medium
- Build: 4.0-dev
- # 32371
- Diff
- richard67:4.0-dev-fix-issue-32370
User tests: Successful: Unsuccessful:
Pull Request for Issue #32370 .
Summary of Changes
Use array_values to fix the array_merge call on PHP 8.
The same fix has been made at other places by other contributors.
Since com_finder was nearly completely rewritten in J4, this PR is made for the 4.0-dev branch and not for staging. In staging I don't see that part of code like it is here.
Thanks @breebee for reporting the issue and proposing the right fix.
Testing Instructions
Have a current 4.0-dev branch or latest 4.0 nightly or latest Beta installation on a server with PHP version 8.
Have a smart search module on the site. If you don't have that because it's a new installation, just install "Sample Data Blog".
In Global Configuration in admin, switch on "Debug System" to see PHP errors and set error reporting to "Maximum".
Use the smart search module on the site.
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Documentation Changes Required
None.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End com_finder |
| Labels |
Added:
?
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32371.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32371.
chmst
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-02-11 10:47:07 |
| Closed_By | ⇒ | chmst | |
| Labels |
Added:
?
|
||
I have tested this item✅ successfully on 81cc552
Tested successfully in Beta8-dev of 10 February in Wampserver 3.2.4 using PHP 8.0.1.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32371.