J4 Issue ? ?
avatar breebee
breebee
9 Feb 2021

Steps to reproduce the issue

Use smart search component on the frontend with a test query

Expected result

Show search results

Actual result

0 array_merge() does not accept unknown named parameters

System information (as much as possible)

Joomla 4 Beta 8 - Dev
PHP 8.0 - fpm
NGINX

Additional comments

I have fixed / bypassed error as follows

components/com_finder/src/Model/SearchModel.php line 289

  • $include = call_user_func_array('array_merge', $this->includedTerms);
  • $include = call_user_func_array('array_merge', array_values($this->includedTerms));
avatar breebee breebee - open - 9 Feb 2021
avatar joomla-cms-bot joomla-cms-bot - change - 9 Feb 2021
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 9 Feb 2021
avatar richard67
richard67 - comment - 9 Feb 2021

@breebee Do you want to make a pull request?

avatar breebee
breebee - comment - 9 Feb 2021

Go for it :)

avatar richard67 richard67 - change - 10 Feb 2021
Title
PHP 8.0 com_finder array issue / solution review
[4.0] PHP 8.0 com_finder array issue / solution review
avatar richard67 richard67 - edited - 10 Feb 2021
avatar richard67 richard67 - change - 10 Feb 2021
Build staging 4.0-dev
avatar alikon alikon - change - 10 Feb 2021
Labels Added: ?
avatar alikon alikon - labeled - 10 Feb 2021
avatar richard67 richard67 - change - 10 Feb 2021
Labels Added: J4 Issue
avatar richard67 richard67 - labeled - 10 Feb 2021
avatar richard67
richard67 - comment - 10 Feb 2021

Ok, will make PR.

avatar richard67 richard67 - change - 10 Feb 2021
Status New Closed
Closed_Date 0000-00-00 00:00:00 2021-02-10 08:51:28
Closed_By richard67
avatar richard67 richard67 - close - 10 Feb 2021
avatar richard67
richard67 - comment - 10 Feb 2021

Closing as having a pull request. Please test #32371 . Thanks in advance.

Add a Comment

Login with GitHub to post a comment