[#32372] - [4.0] Don't attempt to open an empty path
- Closed
- 10 Feb 2021
- Medium
- Build: 4.0-dev
- # 32372
- Diff
- OctavianC:patch-13
User tests: Successful: Unsuccessful:
Pull Request for Issue #32277 .
Summary of Changes
Check that we have a $tempName because fopen('') throws an error on PHP 8
Testing Instructions
Described in #32277 - I have also added a component that can be installed to easily test this happening.
com_uploadtest.zip
- Install com_uploadtest.zip
- Go to Components - Upload Test
- Don't select a file
- Press Send
Actual result BEFORE applying this Pull Request
An error has occurred.
0 Path cannot be empty
Expected result AFTER applying this Pull Request
Successful redirect with 'No file was sent' message.
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Title |
|
||||||
Here's the fixed archive that should install
com_uploadtest.zip
Here's the fixed archive that should install
com_uploadtest.zip
@OctavianC You should update the link in the testing instructions PR description, too.
Testing instructions are for Joomla! 3 - this issue is happening with both 4 and 3. This PR request is for Joomla! 4 right now, and the installable component allows easier testing.
Testing instructions are for Joomla! 3 - this issue is happening with both 4 and 3. This PR request is for Joomla! 4 right now, and the installable component allows easier testing.
I see, thanks for clarification.
@OctavianC But why not fixing it in the staging branch? This would later be merged up into 3.10-dev and 4.0-dev. Or are things so different there that it needs different fixes? Anyway, I'll re-open the issue as it was for 3.x and 4.0, and this PR is only for 4.0.
I think it needs to be fixed in staging here: https://github.com/joomla/joomla-cms/blob/staging/libraries/src/Filter/InputFilter.php#L613 and later be merged up into 4.0-dev, except if @wilsonge is ok with having a merge conflict later.
Yeah staging's better for this. I'll make sure it's merged up once it's merged into staging so will close this PR as a duplicate
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-02-10 13:39:34 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
?
|
||
Can't test this in Joomla 4 (using PHP7): the download test file does not install:
JInstaller: :Install: File does not exist /Users/ceford/Sites/joomla-cms-4/tmp/install_6023bf1789cf1/controllers
Component Install: Failed to copy administrator files.
And the testing instructions are not valid - there is no administrator/components/com_media/views/tmpl/default.php file and there is no <input required anywhere in the component.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32372.