NPM Resource Changed ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
27 Jan 2021

Since the BS5 upgrade some of the rounded corners are incorrect. I have put the corrections in the vendor/bootstrap/_bootstrap-rtl.scss that @infograf768 created.

The existing rounded corners code in the template-rtl.scss file may or may not be needed I didnt check.

scss really isnt my thing

Before

chrome_2021-01-27_22-22-14

chrome_2021-01-27_22-22-54

chrome_2021-01-27_22-23-36

After

chrome_2021-01-27_22-26-02

chrome_2021-01-27_22-25-34

chrome_2021-01-27_22-25-03

avatar brianteeman brianteeman - open - 27 Jan 2021
avatar brianteeman brianteeman - change - 27 Jan 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 27 Jan 2021
Category Administration Templates (admin) NPM Change
avatar bembelimen
bembelimen - comment - 28 Jan 2021

Isn't this more a BS5 RTL issue and should be reported there?

avatar infograf768
infograf768 - comment - 28 Jan 2021

Isn't this more a BS5 RTL issue and should be reported there?

We are not using the bootstrap5 rtl possibilities right now. Thus why we had to create overrides.

avatar ceford
ceford - comment - 28 Jan 2021

Is there an easy way to invoke rtl behaviour? I tried fiddling with direction in the Atum index.php but that did not do anything.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32177.

avatar HLeithner
HLeithner - comment - 28 Jan 2021

I thought we will use bs5 right to left support, shouldn't we work on that instead of do patchwork? I mean it's a bit waste of time or? @dgrammatiko @wilsonge what's missing to use the native RTL support?

avatar wilsonge
wilsonge - comment - 28 Jan 2021

You run this https://rtlcss.com/ as postcss against the generated css file from SCSS (full info https://getbootstrap.com/docs/5.0/getting-started/rtl/) . See #32113 (comment) for some more info

avatar brianteeman
brianteeman - comment - 28 Jan 2021

@ceford you change the value of in the langmetadata.xml file in the admin languages folder

@HLeithner until the build scripts are updated then there is no choice. And @wilsonge has said that they wont be done yet so this just moves us forward.

avatar HLeithner
HLeithner - comment - 28 Jan 2021

Ok just read the comment thx

avatar wilsonge
wilsonge - comment - 28 Jan 2021

And @wilsonge has said that they wont be done yet so this just moves us forward.

Just to be clear if @dgrammatiko or someone contributes it then I'll definitely consider it. I just don't personally have the capacity because I wanna focus on the release blockers and there's a lot more people who can work on scss

avatar dgrammatiko
dgrammatiko - comment - 28 Jan 2021

@wilsonge will do after the joomla update pr

avatar brianteeman
brianteeman - comment - 28 Jan 2021

LEt me know if you need a hand on the update

avatar ceford
ceford - comment - 29 Jan 2021

Fixed as illustrated if Debug System is Yes but not if Debug System is No. I guess that must be in the compilation of the min file. So is this a pass? Really weird to see English ltr layout! Thanks for the tip on how to set this up.

Another odd-ball: In ltr mode in Firefox and Chrome on Mac there is an enormous empty area to the left of the visible page. I can scroll left, and scroll and scroll and scroll but nothing comes into view.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32177.

avatar brianteeman
brianteeman - comment - 2 Feb 2021

Anything holding back this PR from being merged and in the beta 7?

avatar wilsonge wilsonge - close - 2 Feb 2021
avatar wilsonge wilsonge - merge - 2 Feb 2021
avatar wilsonge wilsonge - change - 2 Feb 2021
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-02-02 10:31:19
Closed_By wilsonge
Labels Added: NPM Resource Changed ?
avatar wilsonge
wilsonge - comment - 2 Feb 2021

No - good enough for a first pass

avatar brianteeman
brianteeman - comment - 2 Feb 2021

Thanks

Add a Comment

Login with GitHub to post a comment