NPM Resource Changed ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
27 Jan 2021

Looks like the values for the rtl settings were the wrong way around

Before

image

After

image

avatar brianteeman brianteeman - open - 27 Jan 2021
avatar brianteeman brianteeman - change - 27 Jan 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 27 Jan 2021
Category Administration Templates (admin) NPM Change
avatar infograf768
infograf768 - comment - 28 Jan 2021

Please wait on this one as it could mean there was an error for all ms- class overrides.
Can’t look at it until end of week.

avatar brianteeman
brianteeman - comment - 28 Jan 2021

If there is an error it doesnt have any impact on this PR and can be addressed in its own pr

avatar wilsonge
wilsonge - comment - 28 Jan 2021

This is now the opposite of me-auto which seems logical. I think this is good to merge.

avatar wilsonge wilsonge - change - 28 Jan 2021
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-01-28 10:14:08
Closed_By wilsonge
Labels Added: NPM Resource Changed ?
avatar wilsonge wilsonge - close - 28 Jan 2021
avatar wilsonge wilsonge - merge - 28 Jan 2021
avatar brianteeman
brianteeman - comment - 28 Jan 2021

Thanks

avatar infograf768
infograf768 - comment - 29 Jan 2021

I checked. That one was the only error in the ms- classes. oof

Add a Comment

Login with GitHub to post a comment