[#32176] - Optimize the code introduced with PR 32006 to rename incorrectly cased files on update
- Fixed in Code Base
- 24 Feb 2021
- Medium
- Build: staging
- # 32176
- Diff
- richard67:staging-simplify-fix-filename-casing
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
This Pull Request (PR) simplifies the code in the new function fixFilenameCasing which has been added to script.php with PR #32006 by using old and new paths which begin with a slash, so it doesn't need to prepend the slash every time we use it.
This makes it also consistent with the calling function deleteUnexistingFiles, where the paths of files and folders to be removed also are paths starting with a slash.
Testing Instructions
Check that the testing instructions from PR #32006 still work on a current staging or latest 3.9.x nightly build after the patch of this PR here has been applied.
Use the update package built by drone for this PR for Update.
Actual result BEFORE applying this Pull Request
Works as described in the testing instructions of PR #32006 .
Expected result AFTER applying this Pull Request
Still works as described in the testing instructions of PR #32006 .
Documentation Changes Required
No.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_admin |
I have tested this item
I performed the same tests, this time using https://ci.joomla.org/artifacts/joomla/joomla-cms/staging/32176/downloads/39651/Joomla_3.9.25-dev+pr.32176-Development-Update_Package.zip
The 3 files are now corrected
Update: The 3 files are corrected as well
Win10, PHP8.
Thank you
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32176.
| Labels |
Added:
?
|
||
Be aware that https://ci.joomla.org/artifacts/joomla/joomla-cms/staging/32176/downloads/39651/ was not rebuilt with the latest commit.
I manually updated script.php with the updates from 3960f11 and re-zipped the package.
Ran "Update & Upload", all files are renamed on Windows.
Be aware that https://ci.joomla.org/artifacts/joomla/joomla-cms/staging/32176/downloads/39651/ was not rebuilt with the latest commit.
I manually updated script.php with the updates from 3960f11 and re-zipped the package.
Ran "Update & Upload", all files are renamed on Windows.
@jsubri The link changes after each build. I have made drone build again the packages and just have updated the link in the description of this PR. It is https://ci.joomla.org/artifacts/joomla/joomla-cms/staging/32176/downloads/39683/Joomla_3.9.25-dev+pr.32176-Development-Update_Package.zip now, i.e. build number 39683. Same for the page with all downloads, it is https://ci.joomla.org/artifacts/joomla/joomla-cms/staging/32176/downloads/39683/ now.
I have tested this item
re-tested with the latest Joomla_3.9.25-dev+pr.32176-Development-Update_Package.zip
all good Windows 10.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32176.
FrederikGostn
- 
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32176.
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-02-24 21:35:18 |
| Closed_By | ⇒ | HLeithner |
Thanks merged by CR
Thanks
@jsubri @HLeithner @wilsonge As you had tested PR #32006 , could you test this one here, too? I know, I should have done that immediately with #32006 , that would save you that work for testing now, but I wanted to stay close to the original PR #30802 at that time. Sorry for the additional work.