User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Use a global object named bootstrap
instead of the Joomla.Bootstrap
This is my fault, let me explain: Joomla has 2 instances (tabs and modals) where it kinda uses it's own constructor (eg some specific tasks executed before initialising the interactive elements). When I was implementing this JS part of BS5 I thought a Joomla
registry was a good idea. Never ever ship code that was a nice idea. The problem is that Bootstrap documentation in such case is referring to objects that don't actually exist in the document. I'm sorry, this was a terrible idea
Check the dropdowns in the dashdoard
Check the modals in the Article Edit
Check the Accordion in the Menu edit (select new component)
Check the tabs in the tinyMCE plugin (set0... )
Bootstrap docs don't actually reflect the methods of the interactive components
Code is the same but the Bootstrap docs reflect exactly what exists in our codebase
The Bootstrap Docs is our documentation but we still need to document the Bootstrap.php methods
@wilsonge sorry mate for the mess, this needs to be merged ASAP
Status | New | ⇒ | Pending |
Category | ⇒ | JavaScript Repository NPM Change |
Labels |
Added:
NPM Resource Changed
?
|
Category | JavaScript Repository NPM Change | ⇒ | Repository JavaScript NPM Change Libraries |
But I don't really understand what I am looking for
The changes affect only the exposed global object so it's only for very advanced developers. Thanks for testing
Status | Pending | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-01-26 22:12:01 |
Closed_By | ⇒ | wilsonge |
LGTM and tested myself locally too. Thanks!
Thanks and sorry for the mess
Don't worry :)
I applied the patch, ran npm ci and checked that the various things mentioned still worked. They did. But I don't really understand what I am looking for. Should I expect to see visible changes in the rendered html? I think this is a pass but I am not sure!
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32159.