[#32160] - [4.0] Removing three strings which are not supposed to be translated.
- Fixed in Code Base
- 25 Jan 2021
- Medium
- Build: staging
- # 32160
- Bakual:4_RemoveUselessStrings
#31379 introduced three new language strings. But the strings are technical terms which are not supposed to be translated:
COM_CONFIG_FIELD_WEBSERVICES_CORS_ALLOW_ORIGIN_LABEL="Access-Control-Allow-Origin"
COM_CONFIG_FIELD_WEBSERVICES_CORS_ALLOW_HEADERS_LABEL="Access-Control-Allow-Headers"
COM_CONFIG_FIELD_WEBSERVICES_CORS_ALLOW_METHODS_LABEL="Access-Control-Allow-Methods"
Summary of Changes
This PR removes the strings and "hardcodes" the label to the term. It also adjusts the form XML so it doesn't try to translate the string.
Testing Instructions
Go to global configuration -> server tab. Enable "CORS" and then check the labels of the three "Access-Control-Allow-..." parameters
Actual result BEFORE applying this Pull Request
Strings are translated to the technical term
Expected result AFTER applying this Pull Request
Strings are not translated.
But actually no difference to before the PR.
Documentation Changes Required
None
wilsonge
- | Status | New | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-01-25 21:01:46 |
| Closed_By | ⇒ | wilsonge |
joomla-cms-bot
- | Category | ⇒ | Administration com_config Language & Strings |
Why not use that string to add documentation (link to Mozilla docs) that would explain that technical term similiar how we did in with com_csp?
For the translators we can place a comment asking them not to translate that string.
It's the label of the parameter. There is still a translated description where such things could be added.
LGTM