[#32007] - [4.0] remove images
- Closed
- 11 Jan 2021
- Medium
- Build: 4.0-dev
- # 32007
- Diff
- brianteeman:images
User tests: Successful: Unsuccessful:
Removes the parks and fruit folders from the images/sampledata folder as they are no longer used.
They are already excluded from update packages.
They do not need to be added to the list of files to remove on upgrade as they might be used by a user.
(They are used in the test sampledata plugin but thats not shipped with Joomla and is already pretty broken)
| Status | New | ⇒ | Pending |
testing Sampledata plugin is not shipped with Joomla so no point in shipping the images with joomla
testing Sampledata plugin is not shipped with Joomla so no point in shipping the images with joomla
that's maybe true but removing only a part of it makes no sense, 2 possible solutions
- fixing the testing sample data
- deleting not only a part of it and delete everything (I suspect its only the directory plugins/sampledata/testing and the reference in the build script)
of course moving the images to another folder and fixing the path in the sampledata and exclude them from build process is also an option
fixing the testing sample data
Even when fixed there is no need to ship the images
deleting not only a part of it and delete everything (I suspect its only the directory plugins/sampledata/testing and the reference in the build script)
That is what is currently done in the build scripts ;)
To keep you happy I will just leave these images as they are and remove them in the build scripts.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-01-11 12:14:16 |
| Closed_By | ⇒ | brianteeman | |
| Labels |
Added:
?
|
||
That files are used in the testing sampledata, if you remove the files you also have to remove the sampledata doesn't make sense to keep only the half of the package.