[#32006] - Rename incorrectly cased files on updates or when fixing database
- Fixed in Code Base
- 25 Jan 2021
- Medium
- Build: staging
- # 32006
- Diff
- richard67:staging-sharkykz-fix-file-casing-mod-2
User tests: Successful: Unsuccessful:
Pull Request for Issues #23725 and #30736 .
Replaces Pull Request #30802 .
Summary of Changes
This pull request (PR) attempts to implement case sensitive file rename and rename some incorrectly cased files.
It is based on PR #30802 plus my corrections for OSX.
Thanks to @SharkyKZ for the original PR #30802.
Testing Instructions
Testers please report back which server operating system (Linux, Windows, OSX) you have used for your test. If you have several available, test with all of them.
Install Joomla! <= 3.9.23 => check the following files:
joomla-cms/administrator/components/com_admin/script.php
Lines 2670 to 2674 in f3666c8
Use the update package built by drone for this PR for Update
- Update with the Joomla Updater
- Copy the files via FTP and use "Fix Database"
- Install the installation package built by drone for this PR as a fresh installation
Now check the file list again => files should in all three test cases have the correct name.
Actual result BEFORE applying this Pull Request
Incorrectly cased files present.
Expected result AFTER applying this Pull Request
No incorrectly files after update or database fix or new installation.
Documentation Changes Required
None.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_admin Libraries External Library Composer Change |
| Labels |
Added:
?
?
|
||
I have tested this item
I restored a 3.9.23 site that was upgraded over the years. Upload & Update "Joomla_3.9.24-dev+pr.32006-Development-Update_Package.zip" via Joomla Update.
Before: Stringcontroller.php after: StringController.php
Before: Xsalsa20.php after: XSalsa20.php
Before: no si_LK.gif file (the file might have been forgoten in some 3.x upgrade packages), after: si_lk.gif is present
Windows 10, PHP 8.0
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32006.
use "Fix Database"
The "Fix Database" button really needs to be renamed to "Fix everything" and possibly relocated somewhere else, as it now does a lot more than just apply any pending database schema changes which was its original aim.
The "Fix Database" button really needs to be renamed to "Fix everything" and possibly relocated somewhere else, as it now does a lot more than just apply any pending database schema changes which was its original aim.
Sure, but that's outside the scope of this PR.
Using the "Fix database" button for this is fundamentally wrong.
Joomla 4 has already changed its name to Database: update structure to try to make it clearer that it only touches database structure changes and not any content changes.
Adding a fix files functionality to this button is a step backwards not forwards.
Joomla 4 has already changed its name to Database: update structure to try to make it clearer that it only touches database structure changes and not any content changes.
And that was wrong because currently it still does other stuff, too.
Adding a fix files functionality to this button is a step backwards not forwards.
Yes, but it wasn't in the scope of the original PR #30802 either to fix that all.
I have tested this item
Works on OSX for me PHP 7.3
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32006.
Would be nice to get a test on Linux, too.
Tested on Linux works as expected.
RTC?
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32006.
Please stop your personal attacks. I was asking (!) for RTC cause sometimes it is forgotton.
Please stop to tell us maintainers and JBS members what we shall do. We know it by ourselves.
Please stop to tell us volunteers what we shall do. We know it by ourselves.
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-01-25 10:11:42 |
| Closed_By | ⇒ | rdeutz | |
| Labels |
Added:
?
|
||
@bembelimen @chmst @softforge @wilsonge Please test.