[#31794] - Fix CSS build script to avoid multiple min files (Windows machine)
- Fixed in Code Base
- 29 Dec 2020
- Medium
- Build: 4.0-dev
- # 31794
- Diff
- bembelimen:4.0/31790
User tests: Successful: Unsuccessful:
Pull Request for Issue #31790 .
Summary of Changes
Improve build script for windows machines.
Testing Instructions
See #31790 by using a windows machine
Actual result BEFORE applying this Pull Request
a lot of min.min...min.css files
Expected result AFTER applying this Pull Request
only filename.min.css files
@dgrammatiko I changed your suggestion a bit, but perhaps I'm wrong?
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Repository |
| Title |
|
||||||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31794.
@dgrammatiko I changed your suggestion a bit, but perhaps I'm wrong?
I can't test it but the logic should be like: if the files has a .css extension and the path doesn't have a \template\ or \templates\ or /template/ or /templates/ then do the minification in place (or copy the file to the appropriate path and do the minification there). So I guess you need to negate the last argument (but it might work like that, IDK).
FWIW over 90% of the bugs with the build system are related to the strange filesystem windows uses and all of them were my fault
I have tested this item
Tested on Win10
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31794.
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-12-29 13:04:17 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
Two tests is good enough for me! Thanks!
No undesired effect on MacOS.