? Pending

User tests: Successful: Unsuccessful:

avatar bembelimen
bembelimen
28 Dec 2020

Pull Request for Issue #31790 .

Summary of Changes

Improve build script for windows machines.

Testing Instructions

See #31790 by using a windows machine

Actual result BEFORE applying this Pull Request

a lot of min.min...min.css files

Expected result AFTER applying this Pull Request

only filename.min.css files

@dgrammatiko I changed your suggestion a bit, but perhaps I'm wrong?

avatar bembelimen bembelimen - open - 28 Dec 2020
avatar bembelimen bembelimen - change - 28 Dec 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 28 Dec 2020
Category JavaScript Repository
avatar infograf768 infograf768 - change - 28 Dec 2020
Title
Fix CSS build script to avoid multiple min files
Fix CSS build script to avoid multiple min files (Windows machine)
avatar infograf768 infograf768 - edited - 28 Dec 2020
avatar infograf768
infograf768 - comment - 28 Dec 2020

No undesired effect on MacOS.

avatar Quy
Quy - comment - 28 Dec 2020

I have tested this item successfully on 5a2141d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31794.

avatar Quy Quy - test_item - 28 Dec 2020 - Tested successfully
avatar dgrammatiko
dgrammatiko - comment - 28 Dec 2020

@dgrammatiko I changed your suggestion a bit, but perhaps I'm wrong?

I can't test it but the logic should be like: if the files has a .css extension and the path doesn't have a \template\ or \templates\ or /template/ or /templates/ then do the minification in place (or copy the file to the appropriate path and do the minification there). So I guess you need to negate the last argument (but it might work like that, IDK).
FWIW over 90% of the bugs with the build system are related to the strange filesystem windows uses and all of them were my fault ?

avatar chmst
chmst - comment - 28 Dec 2020

I have tested this item successfully on 5a2141d

Tested on Win10


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31794.

avatar chmst chmst - test_item - 28 Dec 2020 - Tested successfully
avatar wilsonge wilsonge - change - 29 Dec 2020
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-12-29 13:04:17
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 29 Dec 2020
avatar wilsonge wilsonge - merge - 29 Dec 2020
avatar wilsonge
wilsonge - comment - 29 Dec 2020

Two tests is good enough for me! Thanks!

Add a Comment

Login with GitHub to post a comment