[#31793] - [4.0] Handle tags on copy via batch
- Closed
- 30 Dec 2020
- Medium
- Build: 4.0-dev
- # 31793
- Diff
- bembelimen:4.0/31127
User tests: Successful: Unsuccessful:
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31793.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31793.
add PR-4.0-dev label again.
| Labels |
Added:
?
?
|
||
This only works when copying the article.
If it is a simple change (category, language), then we lose the Tag.
We lose everytime the tags when $table->store() is called. That is a fundamental problem, how the taggable plugin is implemented. So we have to touch everywhere, where table is stored in the Joomla! environment. (or rewrite the taggable behaviour). So this PR only solves the issue itself.
Last change after tests and RTC was only code style, so the tests and the RTC are still valid. Restoring the test result in the tracker in a minute.
Holding on merging this until I understand whether this behaviour is needed if the underlying issue in the taggable plugin is fixed. I suspect this is independent but want to do a bit of digging
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-12-30 01:17:46 |
| Closed_By | ⇒ | wilsonge |
I have tested this item✅ successfully on 18a8f4e
Tested successfully in Beta6-dev of 28 December.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31793.