User tests: Successful: Unsuccessful:
Pull Request for Issue # . Part of the Child template effort
TinyMCE respects the paths for child templates
You will need to install the front end template https://github.com/joomla/joomla-cms/files/4977972/siteparent_v2.zip from #30192
The template needs to be default for all the menus
Then copy the file /templates/system/css/editor.css to /media/site/siteparent/css/editor.css
Edit an article (either backend or front end) and observe that the editor.css is loaded in the iframe of tinyMCE
No, feature parity, backward compatibility not broken, Logic is not radically changed, just adopted for the child able templates, also there shouldn't be any performance degradation (it's almost the same amount of commands executed prior or after this PR)
Status | New | ⇒ | Pending |
Category | ⇒ | Front End Plugins |
Labels |
Added:
?
|
I don't think the JPATH_ROOT usage is going to work for files in the media directory for admin templates
I had the same idea BUT the logic never uses the Admin template, it always refers to the active front end template the one that is used (check the where clause in the db query I modified, btw this is not changed here)
Tinymce should be using the site template editor.css whether its in the front end or the admin
I have tested this item
I've installed Siteparent template and made it default.
I've copied the file /templates/system/css/editor.css to /media/templates/site/siteparent/css/editor.css
Before install path, editor iframe loads /templates/system/css/editor.css but after install the path editor iframe loads /media/templates/site/siteparent/css/editor.css
I tried to test this issue but I got an error whe I installed the template.
I installed the template, I selected it as default for all menu items, I emptied joomla cache and the browser cache.
When I loaded the frontend I received the following error
Joomla\CMS\WebAsset\Exception\UnsatisfiedDependencyException:
Unsatisfied dependency "bootstrap.js.bundle" for an asset "template.cassiopeia" of type "script"
at at /libraries/src/WebAsset/WebAssetManager.php:1037
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31785.
Unsatisfied dependency "bootstrap.js.bundle" for an asset "template.cassiopeia" of type "script"
I think you have an outdated Joomla Beta version. Sor sometime now there's no bootstrap.js.bundle
Unsatisfied dependency "bootstrap.js.bundle" for an asset "template.cassiopeia" of type "script"
I think you have an outdated Joomla Beta version. Sor sometime now there's no
bootstrap.js.bundle
Thank you for the tip, however,
I updated my test site to 4.0.0-beta7, before testing.
I have now updatated to 4.0.0-beta8-dev.
Some problem.
I will try on a fresh install if I have some time later on
I will try on a fresh install if I have some time later on
Maybe the provided template needs some update, so give it some time till I get something for you
Sorry but this is not good.
Before this PR the editor.css file provided by the template would be editable in the template manager. By moving it to the media folder it is no longereditable.
Sorry but this is not good.
Sorry, but you totally missing the point here. For legacy templates (eg existing templates) the assets live in the template folder and the script will look there but for the new mode since all the static assets are moved into media/templates/... the script will look there. Nothing is broken here and also the editing will be possible once I finish that com_templates refactoring which is always get postponed due to other more urgent PRs...
Definitely too late for such a major change in 4.0
Definitely too late for such a major change in 4.0
The code is already merged, the only thing missing is the UI, eg the refactoring of com_templates to expose these changes
Is there still a test needed here?
Yes but the code needs to be updated, so it can be tested (right now it can't)
Labels |
Added:
?
Removed: ? |
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-11-12 22:01:41 |
Closed_By | ⇒ | dgrammatiko |
I don't think the JPATH_ROOT usage is going to work for files in the media directory for admin templates