? ? Pending

User tests: Successful: Unsuccessful:

avatar chmst
chmst
26 Dec 2020

Pull Request for Issue #22776 .

Summary of Changes

Fix comments and add a comment for a unclear line

Testing Instructions

Code review

avatar chmst chmst - open - 26 Dec 2020
avatar chmst chmst - change - 26 Dec 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 26 Dec 2020
Category Front End Plugins
avatar brianteeman
brianteeman - comment - 26 Dec 2020

I have tested this item successfully on fce37e6


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31784.

avatar brianteeman brianteeman - test_item - 26 Dec 2020 - Tested successfully
avatar gostn
gostn - comment - 26 Dec 2020

I have tested this item successfully on fce37e6


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31784.

avatar gostn gostn - test_item - 26 Dec 2020 - Tested successfully
avatar Quy Quy - change - 26 Dec 2020
Status Pending Ready to Commit
avatar Quy
Quy - comment - 26 Dec 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31784.

avatar richard67
richard67 - comment - 26 Dec 2020

@Quy Wrong milestone and label? The PR is for staging, not 4.0-dev.

avatar chmst chmst - change - 27 Dec 2020
Labels Added: ? ?
avatar chmst
chmst - comment - 27 Dec 2020

Thank you @richard67 and @Quy this is for stable, but the fix is valid also in J4

avatar wilsonge wilsonge - change - 27 Dec 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-12-27 22:20:11
Closed_By wilsonge
avatar wilsonge wilsonge - close - 27 Dec 2020
avatar wilsonge wilsonge - merge - 27 Dec 2020
avatar wilsonge
wilsonge - comment - 27 Dec 2020

As this is just code comments merging this during the RC Window

Add a Comment

Login with GitHub to post a comment