NPM Resource Changed ? ? Pending

User tests: Successful: Unsuccessful:

avatar infograf768
infograf768
25 Dec 2020

Summary of Changes

As title says

Testing Instructions

Create a smart search module or/and create a smartsearch menu item.
Set Advanced Search parameter to Hide (or, in the module, to Link to Component)

In frontend search for any term.
Look at Console.

Patch, run npm and test again.

Actual result BEFORE applying this Pull Request

Set to Hide

Uncaught TypeError: advanced is null
    onSubmit http://localhost:8888/newfolder/joomla40/media/com_finder/js/finder.js?d95aaed2474d55e8cd9c2b345143f252:54
finder.js:54:9
    onSubmit http://localhost:8888/newfolder/joomla40/media/com_finder/js/finder.js?d95aaed2474d55e8cd9c2b345143f252:54

Set to Link to Component

    Uncaught TypeError: advanced is null
    onSubmit http://localhost:8888/newfolder/joomla40/media/com_finder/js/finder.js?b0b050708b2289022423e09adb1ec45a:54
    onBoot http://localhost:8888/newfolder/joomla40/media/com_finder/js/finder.js?b0b050708b2289022423e09adb1ec45a:77
    onBoot http://localhost:8888/newfolder/joomla40/media/com_finder/js/finder.js?b0b050708b2289022423e09adb1ec45a:76
    EventListener.handleEvent* http://localhost:8888/newfolder/joomla40/media/com_finder/js/finder.js?b0b050708b2289022423e09adb1ec45a:83
    <anonymous> http://localhost:8888/newfolder/joomla40/media/com_finder/js/finder.js?b0b050708b2289022423e09adb1ec45a:84

Expected result AFTER applying this Pull Request

No more Uncaught Error

avatar infograf768 infograf768 - open - 25 Dec 2020
avatar infograf768 infograf768 - change - 25 Dec 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 25 Dec 2020
Category JavaScript Repository NPM Change
avatar infograf768 infograf768 - change - 25 Dec 2020
Labels Added: NPM Resource Changed ?
avatar Fedik
Fedik - comment - 25 Dec 2020

I have tested this item successfully on 0f71893


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31779.

avatar Fedik Fedik - test_item - 25 Dec 2020 - Tested successfully
avatar gostn
gostn - comment - 26 Dec 2020

I have tested this item successfully on 0f71893


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31779.

avatar gostn gostn - test_item - 26 Dec 2020 - Tested successfully
avatar infograf768 infograf768 - change - 26 Dec 2020
Status Pending Ready to Commit
avatar infograf768
infograf768 - comment - 26 Dec 2020

rtc


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31779.

avatar wilsonge wilsonge - change - 27 Dec 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-12-27 19:25:45
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 27 Dec 2020
avatar wilsonge wilsonge - merge - 27 Dec 2020
avatar wilsonge
wilsonge - comment - 27 Dec 2020

Thanks!

Add a Comment

Login with GitHub to post a comment