[#31780] - [4.0] Cassiopeia image select
- Fixed in Code Base
- 18 Feb 2021
- Medium
- Build: 4.0-dev
- # 31780
- Diff
- brianteeman:cass_image_seclect
User tests: Successful: Unsuccessful:
Adds the same scss that is used in the backend for the image select field so that it is styled correctly.
To test dont forget to run npm
Before
After
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Templates (site) NPM Change |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31780.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31780.
Please take off max-width: calc(50vw - 5rem);
Same issue when editing an article when Frontend Images and Links is set.
Sorry but I see no reason to remove that. I stick by this PR as it is
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31780.
@brianteeman why did you add the max-width? For me it looks nicer without.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-02-18 08:26:49 |
| Closed_By | ⇒ | laoneo | |
| Labels |
Added:
?
?
|
||
Thanks @brianteeman for the explanation. Merged this one as it makes sense to have the same behavior on front and back end. @infograf768 can you please make a followup pr with your suggestion on the back and front end then?
I have tested this item✅ successfully on 3de2174
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31780.