[#31730] - Pull request for #27530 - Make dropdown close at clicking anywhere else
- Fixed in Code Base
- 3 Jan 2021
- Medium
- Build: 4.0-dev
- # 31730
- Diff
- coolcat-creations:close-dropdown-on-leave
User tests: Successful: Unsuccessful:
Pull Request for Issue #27530 .
Summary of Changes
I added following lines into the template js file:
headerMoreBtn.addEventListener('click', function () { event.stopPropagation(); headerMoreItem.classList.toggle('active'); }); window.onclick = function(event) { headerMoreItem.classList.remove("active"); }
Testing Instructions
Test if the dropdown is closed when clicking anywhere else
See if the code makes sense - I am not too familiar with Javascript
Actual result BEFORE applying this Pull Request
The dropdown stays open when clicking outside the menu
Expected result AFTER applying this Pull Request
The dropdown closes when clicking outside the menu
Documentation Changes Required
no
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Repository NPM Change |
The code works you just need to fix the code style issues
| Labels |
Added:
NPM Resource Changed
?
|
||
Sorry wrong commit message - hope the cs issues are fixed now
I have tested this item
OK - DWISOTT!
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31730.
@coolcat-creations can you make recommended changes to this PR so Drone can be restarted?
@richard67 there are more cs issues, can you have a look?
@HLeithner It seems not to be code style only, so it might need a JS expert, which I am not for sure. But I'll try what I can do.
@HLeithner It seems I was able to fix it (with help of the linter). I hope I haven't done anything wrong since I'm not an es6 expert.
@ceford Could you test again?
And @brianteeman : Could you give it a test, too?
Thanks in advance.
Thanks @richard67
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31730.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31730.
I have tested this item
OK - it works.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31730.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31730.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-01-03 17:17:56 |
| Closed_By | ⇒ | HLeithner | |
| Labels |
Added:
?
|
||
Thanks
@coolcat-creations Drone reports javascript cs errors: https://ci.joomla.org/joomla/joomla-cms/38392/1/21