Hi Elisa,
With Patch, the Topbar position exist.
For testing purposes, I created 1 custom-module, Title to show and small text. But can't see? [with Preparing content also tried)

Hi Elisa,
With Patch, the Topbar position exist.
For testing purposes, I created 1 custom-module, Title to show and small text. But can't see? [with Preparing content also tried)

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31731.

Thank you thats strange - thanks for reporting - I will look into it.

I have tested this item ✅ successfully on 4cf8f1f

Done:) With more moduls type

The idea is good, but I think we need also some styling for the new position and a meaningful landmark for a11y.

I am not in favour of this change.
It is correct, that many websites use a topbar for example for language selection or important information. But this is individual and must be designed carefully, especially for small devices.

It might be a a11y issue. Modules above the navigation have to be recognized and skipped for non mouse users.

With other module types it works, but I also think, it needs some styling.

If patch is accepted, shall not we add a new lang string in the sys.ini ?

I have tested this item ✅ successfully on 4cf8f1f

OK, I tried again. Custom Module is possible. I didn't see the text, as the default color is: #212529; :-)
temporarily changed to #fff;

About the other points, I don't know.

After dicussion with JAT: As the new position is insinde a landmark (header) id can be used and is no a11y issue.

This can't be tested successfully until the new lang string is added:
#31731 (comment)

thanks, I have lifetime issues getting notifications from github, going to add the string.

@coolcat-creations I was so free to add the language string for you and resolve a merge conflict resulting from this by updating your branch to latest 4.0-dev.

@ChristineWk @adj9 Could you test this PR again? It just needs to check that we have a proper language sting being used in the module position selection for a module instead of "topbar".

@infograf768 I've added a language string. Maybe you can give it a test in case if one of the previous testers is not available anymore?

@richard67
My testsite is available :-)

To be sure, it shows now:

Still have the previous module and in addition now, the second one (Search). But space in between?

@ChristineWk Could you start with a new installation of the package for this PR? Compared to the previous test, in this PR only the new language string TPL_CASSIOPEIA_POSITION_TOPBAR="Top Bar" has been added, but this PR has also been updated to latest changes in the 4.0-dev branch after that, and there might have been made changes which have an impact on CSS here, too.

I know it's a bit work, but we can be sure we don't see old, meanwhile solved CSS issues when testing.

For the new language string just check if for the module the position "Top Bar" is shown instead of "topbar" like it was in previous tests.

Above Status: 4.0.0.beta8-dev from 11april2021. But OK, will install Prebuild Update Package now.

@richard67
got the same result (as on screenshot).
Status now: Site File No Problems 4.0.0-2021-02-28 ‎4.0.0-beta8-dev+pr.31731
Checked also: https://github.com/joomla/joomla-cms/tree/4.0-dev/administrator/components/com_admin/sql/updates/mysql

@ChristineWk So I understand right and it needs some styling for the new module position? Or is it an issue also without this PR that there is too much spacing, e.g. when putting the custom module on position "Search" and order so it comes before the "search" module? If it's also an issue without this PR, I'd say it's a good test here, but if not, we should ping someone for adding some styling.

@richard67
Too much spacing when using two modules on this position.

Position: Top Bar [topbar] works.

@ChristineWk But the markup <p>&nbsp;</p>comes from the custom module's content, or not? What happens if you remove that?

@richard67
Yes, Is saw above markup .... (that's why I made a screenshot :.)
Will check the custom module's content x adv asap.
(was a previous generated custom content) thks for waiting :-)

@richard67

a) OK, I removed the markup <p>&nbsp;</p> in HTML Editor. It was automatically done :-)
b) Will now remove Prebuild Package and should load new one?

b) Will now remove Prebuild Package and should load new one?

@ChristineWk Why that?

@richard67

Due of changes from @Quy? Just reading and reading :-)

@ChristineWk No, that was just a code style change. There might come a small change in the language string, also not really a big thing which requires a new test. Main question now is: Is the spacing issue still there after the change in the markup?

@ChristineWk No, that was just a code style change. There might come a small change in the language string, also not really a big thing which requires a new test. Main question now is: Is the spacing issue still there after the change in the markup?

Aha, I thought, that there is new test required.
No :-) As I wrote, it was seen under HTML Editor. Thks.

@ChristineWk Well if this PR works for you then just mark your test result again in the issue tracker. Thanks in advance, and thanks for testing.

I have tested this item ✅ successfully on 492b480

Now, I will install the Nightly Beta8-dev from today :-)

I have tested this item ✅ successfully on 492b480

Test OK

RTC