[#31710] - [4.0] Add sanity checks on the asset file
- Fixed in Code Base
- 19 Dec 2020
- Medium
- Build: 4.0-dev
- # 31710
- Diff
- wilsonge:fix/asset-file-sanity-checks
User tests: Successful: Unsuccessful:
Pull Request for Issue #30972 .
Summary of Changes
Adds sanity checks in com_template dealing with the asset file. You can no longer delete the file, rename it and it enforces valid JSON (reverting the file contents if there is invalid JSON).
Testing Instructions
Try deleting the asset file from cassiopia - Currently gives a 500 error to the template. After patch blocked
Try renaming the file - same result as above
Try making the file have invalid JSON (by removing a comma or quote etc). - before 500 error on the template. After error message shown and file contents reverted to last stable version
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_templates Language & Strings |
| Title |
|
||||||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31710.
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-12-19 12:17:30 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
?
|
||
Thanks!
But you can still delete index.php :-) :-)
I have tested this item✅ successfully on 9157a53
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31710.